Library Settings Editor should automatically filter when switching OU

Bug #1244547 reported by Pasi Kallinen
20
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Wishlist
Unassigned

Bug Description

If there's a filter set in the Library Settings Editor, it should automatically filter the display when switching OU in the page. Currently, it shows all settings, and you have to click on the "filter" button to apply the filter. This means waiting twice for the list of settings to load, once after switching the OU and second time when filtering.

Kathy Lussier (klussier)
Changed in evergreen:
status: New → Confirmed
importance: Undecided → Wishlist
Revision history for this message
Adam Bowling (abowling) wrote :

Patch added that maintains filter settings until the user clicks "Clear Filter".

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=f224f3d9232242c25e92bc1efc0ee33dc6cca62b

user/abowling/lp1244547_maintain_filter_library_settings

tags: added: pullrequest
Changed in evergreen:
assignee: nobody → Josh Stompro (u-launchpad-stompro-org)
Revision history for this message
Josh Stompro (u-launchpad-stompro-org) wrote :

Confirmed that I see the same issue in a June version of Master.

Unfortunately, I don't see any change in behavior when I test this patch. I can see that the changes are included in the source files, and via debug, view source, but the behavior doesn't change.

1. Add a filter such as "self".
2. See the list of options filtered to that string.
3. Profit.. er change the context location to something else and the filter goes away until the filter button is clicked.

Josh

tags: added: needsrepatch
Changed in evergreen:
assignee: Josh Stompro (u-launchpad-stompro-org) → nobody
Kathy Lussier (klussier)
tags: removed: pullrequest
Revision history for this message
Remington Steed (rjs7) wrote :

I tested Adam's code and made a small change that allows it to work properly. Here's the branch, with my sign-off on his commit, and my additional small commit on top of that.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/rsteed/lp1244547_maintain_filter_library_settings

Remington Steed (rjs7)
tags: added: pullrequest
removed: needsrepatch
Galen Charlton (gmc)
tags: added: signedoff
Changed in evergreen:
milestone: none → 3.0-alpha
Revision history for this message
Galen Charlton (gmc) wrote :

Pushed to master. Thanks, Adam and Remington!

Changed in evergreen:
status: Confirmed → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.