claims_returned and longoverdue counts differ between open-ils.actor.user.checked_out(.count) and open-ils.storage.actor.user.checked_out(.count)

[Jason Boyer]

open-ils.storage.actor.user.checked_out(.count) counts a circ as claims returned or long overdue if the checkin_time is null. the source defined in fm_IDL.xml adds an additional check for xact_finish is null, which makes an item marked claimed return with no fines disappear from the patron's items out screen. It would seem that ignoring the xact_finish date would be more accurate for these 2 statuses.

[Jason Boyer (jboyer)]

Forgot to add, I have a branch with a modified fm_IDL.xml here: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jboyer/claimsret_counts

[Ben Shum (bshum)]

Fixing small typo in huge name of bug, and also adding initial review targets and a pullrequest tag to this for review purposes. Sounds like a bug fix to me.

[Kathy Lussier (klussier)]

Jason,

Could you rebase this branch?

Kathy

[Jason Boyer (jboyer)]

Because I'm stumbling around re:rebasing, there are 2 commits on that existing branch: the one that matters ( c1e920502ded6266a322758d8964e2f96b0adbbd ) and one for a merge that can be ignored. Let me know if there's anything that doesn't work out and I'll just reapply it into a new branch.

Jason

[Michele Morgan (mmorgan)]

Signed off on this. Worked in my testing of claimed returned and longoverdue items with xact_finish dates. Wanted to mention, though that when this fix is put in place, some patrons may have claimed returned items show on their records that previously did not show due to erroneous finish dates in the transaction.

[Michele Morgan (mmorgan)]

Link to signoff branch:
http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mmorgan/lp124164-signoff

[Ben Shum (bshum)]

Picked to master and rel_2_6. Conflict with rel_2_5, so not backported there.