claims_returned and longoverdue counts differ between open-ils.actor.user.checked_out(.count) and open-ils.storage.actor.user.checked_out(.count)

Bug #1241644 reported by Jason Boyer on 2013-10-18
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Medium
Unassigned
2.5
Undecided
Unassigned
2.6
Undecided
Unassigned

Bug Description

open-ils.storage.actor.user.checked_out(.count) counts a circ as claims returned or long overdue if the checkin_time is null. the source defined in fm_IDL.xml adds an additional check for xact_finish is null, which makes an item marked claimed return with no fines disappear from the patron's items out screen. It would seem that ignoring the xact_finish date would be more accurate for these 2 statuses.

Jason Boyer (jboyer) wrote :
Ben Shum (bshum) wrote :

Fixing small typo in huge name of bug, and also adding initial review targets and a pullrequest tag to this for review purposes. Sounds like a bug fix to me.

summary: - claims_returned and longvoerdue counts differ between open-
+ claims_returned and longoverdue counts differ between open-
ils.actor.user.checked_out(.count) and open-
ils.storage.actor.user.checked_out(.count)
Changed in evergreen:
status: New → Triaged
importance: Undecided → Medium
milestone: none → 2.6.0-rc1
tags: added: pullrequest
Changed in evergreen:
milestone: 2.6.0-rc1 → 2.next
no longer affects: evergreen/2.4
Kathy Lussier (klussier) wrote :

Jason,

Could you rebase this branch?

Kathy

Jason Boyer (jboyer) wrote :

Because I'm stumbling around re:rebasing, there are 2 commits on that existing branch: the one that matters ( c1e920502ded6266a322758d8964e2f96b0adbbd ) and one for a merge that can be ignored. Let me know if there's anything that doesn't work out and I'll just reapply it into a new branch.

Jason

Michele Morgan (mmorgan) wrote :

Signed off on this. Worked in my testing of claimed returned and longoverdue items with xact_finish dates. Wanted to mention, though that when this fix is put in place, some patrons may have claimed returned items show on their records that previously did not show due to erroneous finish dates in the transaction.

tags: added: signedoff
removed: pullrequest
Ben Shum (bshum) wrote :

Picked to master and rel_2_6. Conflict with rel_2_5, so not backported there.

Changed in evergreen:
status: Triaged → Fix Committed
milestone: 2.next → 2.7.0-rc
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers