Integrated subscription editor tries to make giant dropdown, fails

Bug #1239822 reported by Dan Wells on 2013-10-14
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
High
Unassigned
2.4
High
Unassigned

Bug Description

From the commit:
When trying to edit a subscription using the new 'integrated' editor, it foolishly tries to populate an unfiltered bre dropdown selector. This works OK in test environments, but (as expected) fails miserably with production-size data sets.

The end result is that the dropdown either never populates, or takes a really long time. If the user saves before the dropdown loads, the associated record ID is lost, and the subscription is no longer properly associated with the record.

To fix this, simply turn the dropdown into a disabled text input instead, as the ability to edit this field would generally be more harmful than it is necessary.

branch at:
http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dbwells/remove_ssub_bre_dropdown

working/user/dbwells/remove_ssub_bre_dropdown

It took me a second to understand why the problem manifests in serial control view only when this code is mostly shared with the alternate serial control view, but I get it now, and I see the correct change in behavior with testing.

Thanks Dan! Signed-off and pushed to rel_2_4 and master.

Changed in evergreen:
status: New → Fix Committed
Dan Wells (dbw2) on 2013-11-11
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers