No Action Occurs When Selecting Acquisition Requests in Patron Account

[Erica Rohlfs]

Evergreen version 2.4.2

Hello!

When selecting Acquisition Requests in a patron’s account (Patron Account-> Other-> Acquisition Requests) no action occurs. Bill verified that the action is linked to a command. However, no further actions occur.

[Srey Seng (sreyseng)]

EG Master (01/10/2014)

On a stock evergreen master build, I can confirm that going to Patron Account-> Other-> Acquisition Requests do open up the Patron Requests UI.

[Erica Rohlfs (erohlfs)]

EG 2.5.1

Thank you for testing this feature in Master. I appreciate it. I just retested it again in 2.5.1 and still no action occurs when I select Patron Account->Other->Acquisitions Requests.

[Srey Seng (sreyseng)]

This is interesting. Retested again, but this time against EG 2.5.1, and I can see the "Patron Requests" UI still.

I checked out tags/rel_2_5_1 to build and used the official Windows staff client, 2.5.1 (http://evergreen-ils.org/downloads/evergreen-setup-2.5.1.exe) against the sample data.

Did a patron search, and retrieve a patron from the search results. Went to Other -> Acquisition Requests, and can see the "Patron Requests" UI.

Also tried creating and using a brand new user profile, with same result.

[Erica Rohlfs (erohlfs)]

Hi Srey,

Thank you very much for conducting further tests.

Galen also helped me conduct more tests, and he discovered something interesting.

When the patron summary is displayed horizontally, no action occurs when selecting the Acquisitions Requests

When the patron summary is displayed vertically, selecting the Acquisitions Request does open the Patron Request UI.

As an aside for others who may be reading this and don’t know how to switch the patron summary from horizontal to vertical, it is Library Setting: Patron circulation summary is horizontal.

I tested this in 2.4.4 and 2.5.1, and the results are the same.

Srey, will you please retest this both ways and see if your findings are the same?
Thank you, again, for taking the time to test this!

[Galen Charlton (gmc)]

I've got a fix in progress and will supply a patch in a few minutes.

[Galen Charlton (gmc)]

A patch is available at the tip of the user/gmcharlt/lp1234201_horizontal_acq_requests branch in the working/Evergreen.git repository:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gmcharlt/lp1234201_horizontal_acq_requests

[Srey Seng (sreyseng)]

Hi Erica,

I retested against stock 2.5.1, and yes, I can confirm your findings. Acquisitions Request option when in vertical patron summary mode does work, however it does not work when in horizontal mode.

I also tested the patch supplied above, and it works as expected, making the Acquisitions Request option work whether in vertical patron summary mode or horizontal patron summary mode.

Thank you for clarifying!

[Galen Charlton (gmc)]

Hi Srey,

Would you mind signing off on the patch and pushing a signoff branch to the working repository?

Regards,

Galen

[Srey Seng (sreyseng)]

Hi Galen,

Yes, no problem. Below is my signoff branch:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sreyseng/lp1234201_horizontal_acq_requests_signoff

Thanks!

[Galen Charlton (gmc)]

Thanks for testing and signing off. I've pushed the patch to master, rel_2_5, and rel_2_4.