omission in the API methods behind the Invalidate functionality in the Patron Editor

[Jason Etheridge]

For example, the method open-ils.actor.invalidate.other_phone is implimented in Actor.pm with sub mark_users_contact_invalid and has a parameter called "Additional note text (optional)". The Patron Editor does not use this parameter (it passes null), but if it did, the parameter would ultimately be ignored. It does not get used by the sub of the same name in BadContact.pm.

For code hygiene, we can either remove the parameter or make use of it.

[Chris Sharp (chrissharp123)]

Branch implementing removal of the unused parameter (which we must not need since this bug is nearly seven years old):

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/csharp/lp1229794_remove_unused_param

[Bill Erickson (berick)]

Bug #1752334 offers an alternate fix to this unused parameter, which I prefer since it requires fewer code changes and allows for future use of the param.