Optimize container filters in QueryParser

Bug #1224593 reported by Mike Rylander
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Undecided
Unassigned
2.4
Fix Released
Undecided
Unassigned

Bug Description

When a container filter is used at the top level of a QueryParser query (that is, in a simple query with no OR-logic branches or explicit nesting groups) we can use an INNER join instead of LEFT + IS NOT NULL.

On at least one production dataset this showed an increase in performance from 20+ seconds to 1ms for the core query.

Because of the pretty massive speed concern, I'd call this a bug, not a feature.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/miker/optimize-container-join

Tags: pullrequest
Revision history for this message
Dan Scott (denials) wrote :

As the person running the production site in question, I'd agree that was a bug. Committed (and thanks for the better fix than what my hamfisted s/LEFT/INNER/ would have been, Mike!)

Changed in evergreen:
status: New → Fix Committed
Dan Wells (dbw2)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.