Silence deprecation warning in OpenILS::Utils::Normalize

Bug #1220387 reported by Jason Stephenson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Undecided
Unassigned

Bug Description

EG Version: master
OSRF Version: master
PG version: Doesn't matter.

Any time a script uses OpenIL::Utils::Normalize Perl complains about Exporter's import symbol being deprecated.

This branch shuts Perl up by not using the import symbol. It hasn't been necessary in, like, ages and none of the other OpenILS code uses it. Frankly, it is quite annoying when you write a lot of custom scripts/programs.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dyrcona/silence-of-the-Normalizer

tags: added: normalizer pullrequest utils
Revision history for this message
Bill Erickson (berick) wrote :

Hmm, this patch does not silence the warning for me. We may be talking about different warnings. I pushed another fix to silence this one:

UNIVERSAL->import is deprecated and will be removed in a future perl at Open-ILS/src/perlmods/lib/OpenILS/Utils/Normalize.pm line 6

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1220387-silence-of-the-Normalizer2-This-Time-Its-Personal

Revision history for this message
Jason Stephenson (jstephenson) wrote :

Bill, you're right. I didn't test my change to see that it didn't work. I never should have added the pullrequest tag.

I'll take a look at yours and push it when I see that it works, as it should.

Revision history for this message
Jason Stephenson (jstephenson) wrote :

Works as advertised! Committed to master.

Thanks, Bill!

Changed in evergreen:
status: New → Fix Committed
Changed in evergreen:
milestone: none → 2.5.0-beta1
Dan Wells (dbw2)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.