PCrudFilterPane can generate illegal queries

Bug #1218446 reported by Pasi Kallinen on 2013-08-29
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Undecided
Unassigned
2.4
Undecided
Unassigned

Bug Description

When using some of the negating filters, such as "not like" or "not between", PCrudFilterPane can generate illegal queries with "undefined" values.

Fix in http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/paxed/pcrudfilterpane-fix

Pasi Kallinen (paxed) wrote :

Branch updated with another small fix, so the user-input text is remembered when changing operators.

Mike Rylander (mrylander) wrote :

Can the second fix get us into trouble when the value from the old widget doesn't make sense for the new operator?

Pasi Kallinen (paxed) wrote :

It checks the type of the input widget, and changing the field on which it operates clears the value. I haven't seen it break yet, but that proves nothing...

Dan Wells (dbw2) on 2013-09-12
tags: added: 2.5-beta-blocker

Tested and works well. Pushed to master and rel_2_4. rel_2_3 has some differences preventing clean application of the patch, and those differences might even be such that the bug can't be reproduced in a 2.3.x release. Leaving rel_2_3 alone until/unless somebody reports a problem there.

Changed in evergreen:
assignee: nobody → Lebbeous Fogle-Weekley (lebbeous)
status: New → Fix Committed
Changed in evergreen:
assignee: Lebbeous Fogle-Weekley (lebbeous) → nobody
Dan Wells (dbw2) on 2013-11-11
Changed in evergreen:
status: Fix Committed → Fix Released
no longer affects: evergreen/2.3
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers