Comment 8 for bug 1210541

Good news, I found time to really look this thing over and added a bunch of changes that would have been really irritating to track down later. The branch above has been updated against master as of 12/3. I may not have time to do much testing before the 7th, so if anyone else has time, try your best to break it!

A few responses re: Michele's notes:

1: Good point, added a check for that.

2: Once the bugs have been shaken out the only way for this to happen is playing around in psql (or pgadmin, etc.). I'd rather that reporting be accurate even though this isn't necessarily the kind of thing that people would often look for. If there are strong feelings either way one more line could be added to the delete protection rule.

3, 5, 6: Should be taken care of. I made the mistake of modeling my deleted location handling too closely on bibs, which you can pull up by id, rather than call numbers, which you can't.

4,7: Anywhere that had "ON DELETE CASCADE" I tried to address in the delete rule, not many things outside of action.circulation depend on them sticking around. I intentionally didn't remove circ rules referencing a deleted location though, but if it's desired those rules could have their active flag turned off. (I didn't want there to be any mysterious changes to circ policies unless you actively make changes to them.)