Expand All button does not work past the 1st page when viewing a large picklist.

Bug #1208613 reported by Dale Rigney
32
This bug affects 5 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned
2.8
Fix Released
Undecided
Unassigned
2.9
Fix Released
Undecided
Unassigned

Bug Description

Select a large list from the Acquisitions --> My Selection List screen. Click on the Expand All button and the items on the page expand with more information. Click on the Next link to bring up page 2 of the list and you will not see the expanded information. When you click on the Expand All link again nothing happens. The JavaScript Console will show the following error message:

Error: TypeError: liRow is undefined
Source File: oils://remote/js/ui/default/acq/common/li_table.js
Line: 1468

This issues was tested on Evergreen 2.4.0.

Revision history for this message
Erica Rohlfs (erohlfs) wrote :

Confirmed that this issue is still affecting version 2.6.0.

Changed in evergreen:
importance: Undecided → Medium
status: New → Confirmed
Revision history for this message
Dan Wells (dbw2) wrote :

Fix pushed to here:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dbwells/lp1208613_li_table_expand_all

working/user/dbwells/lp1208613_li_table_expand_all

I don't think this can reasonably get an automated test, and the original bug description describes well how to reproduce the error.

tags: added: pullrequest
Changed in evergreen:
milestone: none → 2.next
Revision history for this message
Erica Rohlfs (erohlfs) wrote :

The fix works. Thank you, Dan!

"I have tested this code and consent to signing off on it with my name, [Erica Rohlfs] and email address, [<email address hidden>]."

Galen Charlton (gmc)
Changed in evergreen:
milestone: 2.next → 2.10-rc
Kathy Lussier (klussier)
tags: added: signedoff
Revision history for this message
Galen Charlton (gmc) wrote :

Pushed all the way to rel_2_8. Thanks, Dan and Erica!

Changed in evergreen:
status: Confirmed → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.