Lost billing amounts should be more configurable

Bug #1207903 reported by Dan Wells
14
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Wishlist
Unassigned

Bug Description

When an item is marked lost, the user is typically billed for the item. In Evergreen, they can either be charged the amount recorded in the item object, or if that value is blank (or zero), charged a default price (controlled by settings).

Our library averages out the cost and charges a flat rate of $50.00, an option not currently possible without mass-altering our item records.

Code is in progress.

Tags: pullrequest
Dan Wells (dbw2)
Changed in evergreen:
importance: Undecided → Low
importance: Low → Wishlist
Remington Steed (rjs7)
Changed in evergreen:
milestone: 2.5.0-alpha1 → 2.5.0-alpha2
Dan Wells (dbw2)
Changed in evergreen:
milestone: 2.5.0-alpha2 → 2.5.0-beta1
Revision history for this message
Dan Wells (dbw2) wrote :
tags: added: pullrequest
Changed in evergreen:
assignee: Dan Wells (dbw2) → nobody
Revision history for this message
Remington Steed (rjs7) wrote :

Added one commit for release notes. That makes two commits total. I also rebased to master and fixed one merge conflict in the data seed values file.

working/user/rsteed/min_max_item_pricing

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/rsteed/min_max_item_pricing

Dan Wells (dbw2)
Changed in evergreen:
milestone: 2.5.0-beta1 → none
Ben Shum (bshum)
Changed in evergreen:
milestone: none → 2.next
status: New → Triaged
Revision history for this message
Dan Wells (dbw2) wrote :

Since (in retrospect) it wasn't obvious what my branch does if you only look here, here's the commit message:

In addition to a 'default' price when price is missing or zero, we can also accommodate a range of prices by saying it should be at least 'X' and not more than 'Y'. This also allows you to effectively set a fixed price for all lost items by setting min and max to an equal amount.

Revision history for this message
Jeff Godin (jgodin) wrote :

Looks good, and has recently come up in conversation on IRC as another library had need of this feature.

I'll try to get this tested and possibly in master sometime this weekend.

Jeff Godin (jgodin)
Changed in evergreen:
assignee: nobody → Jeff Godin (jgodin)
status: Triaged → In Progress
Revision history for this message
Jeff Godin (jgodin) wrote :

Rebased against current master to resolve minor conflicts due to other permissions being added, stamped upgrade script as 0854 and bumped all permission IDs as needed.

Cherry picked with signoff and pushed to master.

Thanks, Dan, Remington, Calvin!

Changed in evergreen:
status: In Progress → Fix Committed
assignee: Jeff Godin (jgodin) → nobody
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.