Receiving canceled lineitem / copy not fully implemented

[Bill Erickson]

Evergreen 2.4+
Evergreen 2.3 experiences the same issue, but the code has diverged some and this is as much a new feature as a bug. Debatable..

1. Cancel a lineitem from the PO interface.
2. Receive the lineitem
3. The lineitem is now in the 'received' state, but the cancel_reason is still attached to the lineitem. Ditto the linked, canceled copies.

This was discovered as a result of testing bug #1029591, which surfaces the cancel_reason to the UI.

If the lineitem/copies are received, the cancel_reason value should be cleared (set to NULL).

Question: What should we do about cancel_reason's that have keep_debits=false ? These items will have no debits attached. Should the receive action be prevented? Should the system attempt to recover the debits (using the estimated_price from the lineitem)? Org settings?

Note that even if no debits exist, they will be created during invoicing as needed, so it may not be a problem at all.

[Christine Morgan (cmorgan-z)]

I would say, receiving should be possible for lineitems with cancel_reasons that have keep_debits=false and that the debits should be recovered using the estimated price. If a line item is mistakenly canceled using a cancel_reason that does not retain debits, there is a need to be able to correct the error. If the line item was canceled in error, invoicing may not take place immediately, so reinstating the debit is important. Further, once the lineitem/copies are marked received, it should be possible to un-receive them to set them back to a state of on-order.

[Bill Erickson (berick)]

Thanks for the feedback, Christine.

I've pushed a branch:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1206649-receive-canceled-lineitems

From the commit:

Clear the cancel reason when a canceled lineitem is marked as received. With items, clear the cancel reason and re-generate fund debits if they were removed during cancelation (because the keep_debits flag in the cancel reason was set to false).

[Tim Spindler (tspindler-cwmars)]

I know I am a late comer on this but I agree with Christine.

[Mike Rylander (mrylander)]

Thanks, Bill, Christine and Tim!