Action trigger Granularity strings saving label not value
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Evergreen |
Triaged
|
Medium
|
Unassigned |
Bug Description
Evergreen 2.4
Open-ILS/
<div class='hidden'>
<select dojoType=
<option value='hourly'>[% l('Hourly') %]</option>
<option value='daily'>[% l('Daily') %]</option>
<option value='weekly'>[% l('Weekly') %]</option>
<option value='monthly'>[% l('Monthly') %]</option>
<option value='yearly'>[% l('Yearly') %]</option>
</select>
</div>
when saving the action trigger the string with the capital first letter (eg: "Daily") is saved to the database not the lower case value string.
The action trigger cron job, when specifying granularity takes capitals into account. Therefor action triggers with granularity set made after an upgrade will not work with the cron job set up for previous versions of evergreen.
Simple solution, change the strings to be lower case. Proper fix: have the value saved not the label.
Changed in evergreen: | |
status: | New → Confirmed |
Changed in evergreen: | |
assignee: | Bill Erickson (erickson-esilibrary) → nobody |
Changed in evergreen: | |
milestone: | 2.7.2 → 2.7.3 |
Changed in evergreen: | |
milestone: | 2.8-beta → 2.next |
Changed in evergreen: | |
milestone: | 2.next → 2.9-alpha |
Changed in evergreen: | |
milestone: | 2.9-alpha → 2.9-beta |
no longer affects: | evergreen/2.6 |
Changed in evergreen: | |
milestone: | 2.9-beta → 2.9.0 |
summary: |
- Action trigger Granularity strings saving lable not value + Action trigger Granularity strings saving label not value |
Changed in evergreen: | |
assignee: | nobody → Kathy Lussier (klussier) |
tags: |
added: actiontrigger removed: action trigger |
tags: |
added: needswork removed: needsrepatch |
Changed in evergreen: | |
status: | Confirmed → Triaged |
milestone: | 3.next → none |
Also: If the UI is used in some other language than English, the granularity will be the translated string.