Untranslatable strings in some javascript widgets

Bug #1199302 reported by Pasi Kallinen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Undecided
Unassigned

Bug Description

*EG master

AutoGrid, EditPane, FlattenerGrid, GridColumnPicker and HoldingCode contain some hard-coded strings. Branch to make them translatable is in user/paxed/autogrid-etc-i18n

I do have to admit I haven't yet tested the GridColumnPicker and HoldingCode widgets, as I can't seem to be able to find where those are used, or I don't have data to use them.

Revision history for this message
Lebbeous Fogle-Weekley (lebbeous) wrote :

Thanks Pasi. This tested well in general. I made inconsequential commit message and string changes, and moved one actual line of code in GridColumnPicker.js before pushing to master and rel_2_5.

IIRC, with our current translation processes it wouldn't do us much good to backport to rel_2_4 and on back, but if somebody knows better it's not too later.

Thanks again.

Changed in evergreen:
milestone: none → 2.5.1
no longer affects: evergreen/2.5
Changed in evergreen:
status: New → Fix Committed
Ben Shum (bshum)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.