open-ils.search.zip has a hard-coded zip format

Bug #1196393 reported by Pasi Kallinen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Triaged
Medium
Unassigned

Bug Description

Zips.pm has:

$zip =~ s/(^\d{5}).*/$1/; # we don't care about the last 4 digits if they exist

This may not work for everyone - perhaps we should use ui.patron.edit.aua.post_code.regex OUS if it's set.

Tags: i18n
Ben Shum (bshum)
Changed in evergreen:
importance: Undecided → Low
status: New → Triaged
Revision history for this message
Christopher Burton (cburton) wrote :

Agreed. Canada follows 1N1 N1N which is much different.
The regex being set in the library settings editor for postal code could possibly be used in its place as suggested

Revision history for this message
Rogan Hamby (rogan-hamby) wrote :

I'm questioning a single regular expression. I can imagine either wanting none or support multiple but not one. Sure, some libraries may use only a single postal code but even, say, in the middle of the United States, an out of country address is hardly unknown. And I can easily imagine libraries in border regions that would need multiple patterns.

If we need multiple would a separate management panel of postal code pattern, pre-populated with common ones, be better?

Revision history for this message
Rogan Hamby (rogan-hamby) wrote :

Also, since Evergreen has a significant non-US user base I'm moving this up to medium importance.

Changed in evergreen:
importance: Low → Medium
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.