TPAC reports hold "ready for pickup" before hold_shelf_status_delay expires

[Bill Ott]

ver. 2.2, but suspected all versions

In the summary of myopac, the integer for "Items ready for pickup" will display a count for items that are meant to be masked from the patron via circ.hold_shelf_status_delay. Confusion is caused when the individual hold display does not report the same number of holds actually available for pickup.

In Actor.pm, open-ils.actor.user.hold_requests.count, does not take into consideration the org_unit_setting noted.

[Bill Ott (bott)]

I've created a patch which will consider the aous for each current_shelf_lib and compare the delay before displaying the count value.

Unfortunately, the OPAC and the staff client both utilize this same code. So, both will impacted by the delay.

[Bill Ott (bott)]

Argh! I missed a line in the commit.

[Ben Shum (bshum)]

Hey Bill, can you throw this into a branch with your proper name/git signoff? The patches included are from one of your servers I'm guessing.

Thanks!

[Shae (shae-esilibrary)]

At version 2.4.2 no patch appears to be in place for this. I tested on a training system in house to confirm it is still happening. Hold shelf status delay is set to 30 minutes but, as soon as I captured two holds for my account, it shows in the staff client and TPAC 2 holds ready for pickup for the patron. As far as I know from working with customers, this delay is working as expected as far as preventing the user from getting an actual email notification of the holds being ready for pickup.

[Erica Rohlfs (erohlfs)]

I marked this bug invalid, because the library setting does control the behavior of when we see the Status of the lineitem on hold update. Until the time interval passes as defined by the Library Setting: Hold Shelf Status Delay, the hold's Status column continues to display the Estimated Wait (on an out-of-the-box configuration). Once the time interval has passed, the Status column updates with Available for the hold.

[Kathy Lussier (klussier)]

I'm going to bounce this one back to Confirmed and re-target to supported releases. This is what I see when using the setting on the stock system. I set the delay to one hour. When the hold is captured, I log into the patron's account:

The status column does indeed show x hold on y copies in the status column when the patron accesses my account. This is what Erica describes, but is not the problem area identified in the original report.

In the patron's dashboard, it displays as "1 Ready for Pickup". This is the bug. It shouldn't be showing that there are any holds ready for pickup.

If I click on the "1 Ready for Pickup" link or if I click the link to only show available holds, it will show the hold that was just captured, even though the status doesn't yet identify it as being available.

[Kathy Lussier (klussier)]

Actually, I decided not to re-target to current release since it looks like work is still required on the patch. But I set 2.3 and 2.4 to Won't Fix.