Avoid performing actions on non-relevant ACQ lineitems

[Bill Erickson]

There are a number of actions in the acquisitions top-level actions drop-down meant to apply to batches of lineitems. In many case, the interface is attempting to perform actions against lineitems in nonsensical ways. A simple example is an attempt to cancel an already-canceled lineitem. Of particular interest are the following actions:

create PO
add to PO
create invoice
add to invoice
cancel lineitem
mark selector ready
mark order ready
mark received

Code coming forthwith to apply some additional filters to selected lineitems before applying these actions.

[Bill Erickson (berick)]

Code pushed to:

working/user/berick/lp1193095-acq-batch-actions-filtering

This touches a lot of actions, so testing is much appreciated.

[Bill Erickson (berick)]

For further reference, from the commit:

Avoid applying the following actions to lineitems which are in a state where each action makes no sense.

The following actions are affected. For each, the set of states for which a lineitem must be in for the action to proceed is listed.

    create PO
        - new selector-ready order-ready approved
    add to PO
        - new selector-ready order-ready approved
    create invoice
        - !cancelled
    add to invoice
        - !cancelled
    cancel lineitem
        - !cancelled
    mark selector ready
        - new
    mark order ready
        - new selector-ready
    mark received
        - pending-order on-order

Depending on the interface, some top-level lineitem actions may be globally disabled. The list of states listed above represent the bare minimum requirements.

[Jennifer Pringle (jpringle-u)]

I notice that under mark received the state pending-order is listed as one of the states where this function should work. I don't believe we want it to be possible to receive an item that is pending-order as that then makes it impossible to activate the purchase order.

[Bill Erickson (berick)]

Hi Jennifer, thanks, that makes sense. I was going to apply a patch for this, but realized as I was testing that we are already protecting against this scenario. The "Mark Selected Lineitems as Received" action in the selector is only active/usable after the PO has been activated (and the lineitems are "on-order"). So, while the code in my branch would not prevent a pending-order lineitem from being received, there is actually no way to do it in practice.

[Mike Rylander (mrylander)]

Let the unblocking commence!