Serials: staff client "Edit MFHD" menu shows records that don't exist

[Lebbeous Fogle-Weekley]

Observed in Evergreen 2.2.2:

When staff, using a staff client in TPAC mode, visit the record detail page of a bib with attached subscription, distribution, and basic_summary, but no MFHD records, they can then go to "Actions for this Record" -> "MFHD Holdings" -> "Edit MFHD Record" where they'll see "Some Org Unit (1)" even though no MFHD records to edit actually exist.

Clicking on that "Some Org Unit (1)" leads to this:

Tue Jun 18 2013 14:01:43 GMT-0400 (Eastern Daylight Time)

Create MFHD failed

{
"message":"r is null",
"fileName":"chrome://open_ils_staff_client/content/cat/opac.js",
"lineNumber":699,
"stack":"open_mfhd_editor(-1)@chrome://open_ils_staff_client/content/cat/opac.js:699\noncommand(
[
object XULCommandEvent
]
)@chrome://open_ils_staff_client/content/cat/opac.xul:1\n",
"name":"TypeError"
}

I believe this might be basically a TPAC variant of the earlier JSPAC bug 791974 (thanks to Dale Rigney for legwork on this), but it calls for a different solution.

[Andrea Neiman (aneiman)]

This refers to the XUL client and does not appear to still be a problem in the web client.