backdate post checkin voids an extra day of fine

[[e-mail]]

EG2.4

We ruled out grace period factor.

[Jason Etheridge (phasefx)]

Tina, do you think Daylight Savings Time might be a factor?

[[e-mail] (tji)]

It looks like it is related to the timestamp of the checkin effective time. The time part is hidden in Effective Date. But it's actually different on regular backdated checkin and backdated post checkin.

When I do a regular backdated checkin, I choose Jan 2, 2014 as the Effective Date. The checkin_time in action.circulation is 2014-01-02 23:59:00-08. When do a backdate post checkin, I choose Dec 26, 2013 as the Effective Date, the checkin time in action.circulation is 2013-12-26 00:00:00-08. All fines bear the timestamp of 23:59:59. So Dec 26 is voided.

[Jason Stephenson (jstephenson)]

I have confirmed what Tina reports above not only in the database but running open-ils.circ through the Perl debugger.

The question is, do we want to set the time to 23:59:59 on post-checkin backdate, leave it at midnight, or use the current time?

For what its worth, it looks like a normal back dated checkin uses 23:59:59.

[[e-mail] (tji)]

I am still seeing the issue on 2.8.

I think the effective time should be the same for both regular back dated checkin and post-checkin.

Tina/BC Libraries CO-op