clean up some tests in perlmods/t

Bug #1190717 reported by Jason Etheridge
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Undecided
Unassigned

Bug Description

collab/phasefx/test_cleanup
http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/collab/phasefx/test_cleanup

This fixes a line in Z3950.pm, and adds a new test to 14-OpenILS-Utils.t

This also adds a new dependency, the perl module Test::Warn, which I've added to Makefile.install

Testing needed, particularly for Fedora. Thanks!

-- Jason

Changed in evergreen:
milestone: none → 2.5.0-m2
Revision history for this message
Bill Erickson (berick) wrote :

I'm not able to test Fedora.. but I have pushed sign-offs to working/user/berick/lp1190717-util-test-signoffs.

A made a small change to the Utils.t patch to avoid a new perl warning:

    --
    Bill moved the @comp_holdings variable declaration outside of the
    warning_like block to avoid a new warning:

    Name "main::comp_holdings" used only once: possible typo at
    t/14-OpenILS-Utils.t line 42.
    ---

Works fine. Sanity check appreciated.

Changed in evergreen:
status: New → Confirmed
Revision history for this message
Bill Erickson (berick) wrote :

Also added "libtest-warn-perl" to the squeeze/wheezy makefile mods for bug #1190279

Dan Wells (dbw2)
Changed in evergreen:
milestone: 2.5.0-m2 → 2.5.0-alpha1
tags: added: qaproject
Revision history for this message
Mike Rylander (mrylander) wrote :

Picked two 2 commits into master. Thanks!

Changed in evergreen:
status: Confirmed → Fix Committed
Ben Shum (bshum)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.