Ad Block Plus EasyList blocks advanced search images

[Pasi Kallinen]

*EG master

The Ad Block Plus EasyList has a filter that blocks "/images/adv_" - this matches the advanced search row removal and plus and minus signs. Even though this isn't an Evergreen bug, I don't think that particular filter will be removed from the ABP EasyList without very strong incentive to do so - I doubt minor loss of functionality in Eg is enough for them.

We should probably rename the adv_* images, perhaps to search_adv_* would do the trick.

[Jason Stephenson (jstephenson)]

And then play whack-a-mole as Ad Block changes.....

[Jason Etheridge (phasefx)]

Or just spell out the word "advance", since advertisers apparently
haven't caught on that there are heuristics that look for "adv", and
Ad Block Plus EasyList and other ad blockers may use variations of
that on an ongoing basis.

[Jason Etheridge (phasefx)]

Actually, thinking about it more, we may need to get away from "adv"
altogether. Maybe use expert instead.

[Dan Pearl (dpearl)]

Fix at:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dpearl/img

[Dan Scott (denials)]

Shouldn't some CSS or HTML files change along with the renamed image files? Looks like only part of the commit is there.

[Dan Pearl (dpearl)]

I thought everything was there. I'll look into Dan Scott's concern.

[Dan Pearl (dpearl)]

Dan Scott was right. Some files were missing from the commit. They are there now. Good catch, Dan!

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dpearl/img

[Kathy Lussier (klussier)]

I tested this in a browser where AdBlock was enabled. all of my search row removal images have been restored.

Signed off at

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/kmlussier/lp1190508-img

[Ben Shum (bshum)]

Picked to master. Thanks everyone!