Remove obsolete OpenILS::Utils::Editor

[Jeff Godin]

From my reading/understanding, OpenILS::Utils::CStoreEditor has replaced OpenILS::Utils::Editor, and OpenILS::Utils::Editor can be removed with a small amount of effort.

Some libraries still include OpenILS::Utils::Editor, or a mix of that and OpenILS::Utils::CStoreEditor. The majority of the code has moved to OpenILS::Utils::CStoreEditor.

A lightly-tested experiment to remove OpenILS::Utils::Editor is available in the working repository, and I'd be interested in input from any others whose experience goes back farther than mine.

[Jeff Godin (jgodin)]

working branch: user/jeff/remove_obsolete_editor

gitweb: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jeff/remove_obsolete_editor

[Bill Erickson (berick)]

+1 to removing ::Editor. Since open-ils.storage should not be used for basic CRUD operations, it no longer serves any purpose.

[Bill Erickson (berick)]

I've pushed another branch with sign-off to Jeff's commit plus a follow-up commit with a few minor repairs.

working/collab/berick/lp1187035-remove-obsolete-editor

-----
From the commit:

    * Address 2 places where we were calling $e->request with a CStoreEditor for a storage method. Since CStoreEditor assumes all calls go to open-ils.cstore, these would have failed.

    * While we're in a cleaning mood, remove some obsolete commented code.
-------

I tested all of the affected API calls w/ both commits installed and found no failures.

[Jeff Godin (jgodin)]

Rebased to current master and pushed a new working branch with signoff on Bill's commit. Added one final commit to remove Editor.pm from the MANIFEST file, tested. Looks good.

Adding pullrequest tag for updated branch user/jeff/remove_obsolete_editor_rebase located at:
http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jeff/remove_obsolete_editor_rebase

[Bill Erickson (berick)]

make livecheck FTW!

Found a few lingering issues in ClosedDates.pm where the new CStoreEditor was not managing transactions correctly. Pushed fixes for those, plus a live test for closed date updating. (Create and delete are already handled in the test).

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/collab/berick/lp1187035-remove-obsolete-editor

[Jeff Godin (jgodin)]

Tested and signed off on Part 4, pushed to master. Thanks Bill!