Remove obsolete OpenILS::Utils::Editor

Bug #1187035 reported by Jeff Godin on 2013-06-03
This bug affects 1 person
Affects Status Importance Assigned to Milestone

Bug Description

From my reading/understanding, OpenILS::Utils::CStoreEditor has replaced OpenILS::Utils::Editor, and OpenILS::Utils::Editor can be removed with a small amount of effort.

Some libraries still include OpenILS::Utils::Editor, or a mix of that and OpenILS::Utils::CStoreEditor. The majority of the code has moved to OpenILS::Utils::CStoreEditor.

A lightly-tested experiment to remove OpenILS::Utils::Editor is available in the working repository, and I'd be interested in input from any others whose experience goes back farther than mine.

Bill Erickson (berick) wrote :

+1 to removing ::Editor. Since should not be used for basic CRUD operations, it no longer serves any purpose.

Jeff Godin (jgodin) on 2013-06-05
Changed in evergreen:
assignee: nobody → Jeff Godin (jgodin)
Bill Erickson (berick) wrote :

I've pushed another branch with sign-off to Jeff's commit plus a follow-up commit with a few minor repairs.


From the commit:

    * Address 2 places where we were calling $e->request with a CStoreEditor for a storage method. Since CStoreEditor assumes all calls go to open-ils.cstore, these would have failed.

    * While we're in a cleaning mood, remove some obsolete commented code.

I tested all of the affected API calls w/ both commits installed and found no failures.

Ben Shum (bshum) on 2013-07-25
Changed in evergreen:
status: New → In Progress
Jeff Godin (jgodin) on 2014-02-11
Changed in evergreen:
milestone: none → 2.6.0-beta1
Jeff Godin (jgodin) wrote :

Rebased to current master and pushed a new working branch with signoff on Bill's commit. Added one final commit to remove from the MANIFEST file, tested. Looks good.

Adding pullrequest tag for updated branch user/jeff/remove_obsolete_editor_rebase located at:;a=shortlog;h=refs/heads/user/jeff/remove_obsolete_editor_rebase

Changed in evergreen:
status: In Progress → New
assignee: Jeff Godin (jgodin) → nobody
tags: added: pullrequest
Bill Erickson (berick) on 2014-02-18
Changed in evergreen:
assignee: nobody → Bill Erickson (erickson-esilibrary)
status: New → In Progress
Bill Erickson (berick) wrote :

make livecheck FTW!

Found a few lingering issues in where the new CStoreEditor was not managing transactions correctly. Pushed fixes for those, plus a live test for closed date updating. (Create and delete are already handled in the test).;a=shortlog;h=refs/heads/collab/berick/lp1187035-remove-obsolete-editor

Jeff Godin (jgodin) wrote :

Tested and signed off on Part 4, pushed to master. Thanks Bill!

Changed in evergreen:
status: In Progress → Fix Committed
assignee: Bill Erickson (erickson-esilibrary) → nobody
tags: removed: pullrequest
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers