Remove obsolete methods from open-ils.collections

[Jeff Godin]

The collections service API method open-ils.collections.users_owing_money.retrieve is currently non-functional, and I was unable to find any code or vendor making use of it.

Two options: fix it, or remove it. I opted for the latter.

The removed API method is most similar to the method open-ils.collections.users_of_interest.retrieve, though they are not a 100% match. There is of course the related but less-similar API method open-ils.collections.users_of_interest.warning_penalty.retrieve.

All three of the mentioned methods report on users owing a certain amount of money, and may be used to find users who may be eligible to be placed into collections.

In soliciting information from the one known vendor to use this service, they "do not use [the users_owing_money method]", and (with a hefty IIRC), "it was to be used as a reporting tool, but never was actually put into an application".

If anyone has a reason why open-ils.collections.users_owing_money.retrieve should be maintained/fixed/replaced rather than removed, please speak up. Likewise, anyone in agreement with removing it, especially with knowledge of this code, feel free to concur.

My intent would be to clean up this commit / commit msg and add a pullrequest tag within the week.

[Jeff Godin (jgodin)]

working branch: user/jeff/remove_obsolete_collections_code

gitweb: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jeff/remove_obsolete_collections_code

[Bill Erickson (berick)]

I'd say you covered the bases (it's broken and no one we know is using it). As such, I'm also in favor of removing the API call.

[Jeff Godin (jgodin)]

Rebased to current master (whitespace!) and performed basic testing. New working branch is user/jeff/remove_obsolete_collections_code_rebase located here: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jeff/remove_obsolete_collections_code_rebase

Adding pullrequest tag.

[Bill Erickson (berick)]

Was about to merge this when I noticed a seemingly errant change in the patch. See the first change in

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commitdiff;h=69c14c8035829b3ac553c56e060160a09a9a1ead#patch2

- my $descendants = "actor.org_unit_descendants((select id from actor.org_unit where shortname = ?))";

In sub new_collections(). It seems out of place. Is that intentional? It's clearly not needed. Just some cleanup?

[Bill Erickson (berick)]

Meh, ignore my last comment. It's all good. Merged to master (2.6).

[Jeff Godin (jgodin)]

Bill-

Thanks!

And yes, the $descendants line caught my eye when I revisited this -- I confirmed it was intentional cleanup, but unrelated enough that I probably should have called it out at least in the commit message.

Thanks for committing!

-jeff