acq.cancel_reason table label and description not picked up for translation

Bug #1184655 reported by Pasi Kallinen
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned

Bug Description

*EG master

Most of the inserts to acq.cancel_reason in 950.data.seed-values.sql do not contain the oils_i18n_gettext() marker. The label and description fields aren't marked as translatable in fm_IDL.xml either.

Revision history for this message
Pasi Kallinen (paxed) wrote :

Branch user/paxed/lp1184655 marks the acqcr labels and descriptions as translatable. While doing this, I noticed the three already translatable ones were marked as labels when they should've been descriptions, and one of them had a wrong id number. (Or at least I think those were wrong...)

Pasi Kallinen (paxed)
tags: added: pullrequest
Pasi Kallinen (paxed)
Changed in evergreen:
milestone: none → 2.5.0-m2
Dan Wells (dbw2)
Changed in evergreen:
milestone: 2.5.0-m2 → 2.5.0-alpha1
Ben Shum (bshum)
Changed in evergreen:
importance: Undecided → Medium
status: New → Triaged
Remington Steed (rjs7)
Changed in evergreen:
milestone: 2.5.0-alpha1 → 2.5.0-alpha2
Dan Wells (dbw2)
Changed in evergreen:
milestone: 2.5.0-alpha2 → 2.5.0-beta1
Dan Wells (dbw2)
tags: added: 2.5-beta-blocker
Changed in evergreen:
assignee: nobody → Lebbeous Fogle-Weekley (lebbeous)
Revision history for this message
Lebbeous Fogle-Weekley (lebbeous) wrote :

Thanks Pasi. I agree with you on fixing the ID mismatch and the label->description mismatches from before. The seed data file loads successfully in my tests.

Pushed to master.

Changed in evergreen:
status: Triaged → Fix Committed
Changed in evergreen:
assignee: Lebbeous Fogle-Weekley (lebbeous) → nobody
Dan Wells (dbw2)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.