Subrequest returns spurious post-complete values
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenSRF |
Fix Released
|
Medium
|
Unassigned | ||
2.1 |
Fix Committed
|
Medium
|
Unassigned | ||
2.2 |
Fix Released
|
Medium
|
Unassigned |
Bug Description
From the commit at the tip of http://
Subrequests (AKA method_
final-lvalue responses to the response list even after respond_complete()
has been called from within the implementation method. This commit
discards all post-respond_
spurious values being returned to the ultimate client.
This is important because, while remote requests actively discard post-complete RESPONSE messages, subrequests against local API methods do not and end up passing them back to remote callers. This causes a change in response behavior between atomic and non-atomic versions of a method, as the atomic wrapper uses a subrequest to gather results.
Changed in opensrf: | |
milestone: | none → 2.3.0-beta |
Changed in opensrf: | |
status: | Fix Committed → Fix Released |
Confirmed that the changes in the branch resolve the issue where it was first spotted. I've pushed a signed-off commit to
working/ user/berick/ safer-subreques t-respond- complete- signoff
I'll run this patch on my test server a little longer...