PO 'Apply Order Identifiers' action easy to miss

Bug #1179609 reported by Bill Erickson on 2013-05-13
This bug affects 2 people
Affects Status Importance Assigned to Milestone

Bug Description

Evergreen 2.4+

The "Apply Order Identifers" link along the top of the PO UI is easy to miss when building purchase orders. This is probably because the apply action is not visually linked to the action of changing identifiers -- it's just a link off by itself. This can lead to users applying identifier values and then losing the changes as other changes cause a page reload or as the user simply navigates away before saving.

Two possible solutions include 1) applying the values in real time (onchange) and 2) warning users when they have unsaved changes.

Pushing code to implement option (1) as an shortly.

Bill Erickson (berick) wrote :

Code at working/user/berick/acq-order-ident-apply-inline

From the commit:

When the identifier value for a linetiem is changed, apply the change and refresh the lineitem in real time instead of requiring users to click the 'Apply Lineitem Identifier' link.

The 'Apply Lineitem Identifier' link has also been removed, since it is no longer needed.

When an update is applied and the lineitem is refreshed, the lineitem is also focused to ensure the action of removeing + adding the linetiem to the table does not allow the lineitem to scroll off the page. It also acts as a confirmation the action completed.

Changed in evergreen:
assignee: Bill Erickson (erickson-esilibrary) → nobody
milestone: none → 2.4.1
tags: added: pullrequest
Ben Shum (bshum) on 2013-05-24
Changed in evergreen:
status: New → Triaged
importance: Undecided → Medium
Kathy Lussier (klussier) wrote :

Hi Bill,

This works well and I like the visual cue that the border provides. I have one question before signing off on it. When the lineitem refreshes, we found that the screen was fairly jumpy because the lineitem is pushed to the bottom of the screen - http://www.screencast.com/t/5cbH8p4vLo.

I know this is because you focused the lineitem to ensure it doesn't scroll of the page. Am I understanding correctly that, if you weren't focusing the lineitem here, then the user would return to the top of the PO again? I think our preference is to take the jumpiness over losing sight of the lineitem, but I'm just wondering if there is a way it can be minimized.


Bill Erickson (berick) wrote :

Good point, Kathy. Since we're not re-drawing the page, focusing the lineitem to ensure that it stays visible is not even necessary. I've force-pushed to the same branch a change which removes the focusing and should prevent the page jumping. Now the confirmation that the update succeeded is seeing the identifier value just under the title/author updating to the new value.


Bill Erickson (berick) wrote :

Pushed to master and rel_2_4. Thanks, Kathy.

Changed in evergreen:
status: Triaged → Fix Committed
Ben Shum (bshum) on 2013-07-23
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers