can't renew items on OPAC due to items being on Booking resource list

Bug #1175711 reported by tji@sitka.bclibraries.ca on 2013-05-02
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Medium
Unassigned
2.8
Undecided
Unassigned
2.9
Undecided
Unassigned

Bug Description

EG 2.2.5 & 2.4

Encountered the following error when trying to renew items on OPAC, which are marked as bookable items (records created in booking.resource). No problem when renewing on the Staff Client.

On 2.2.5, it simply shows Renewing.......

The error from Firefox console:

debug: osrfMethodException : *** Call to [open-ils.circ.renew] failed for session [xxxxxxxxxxxxx], thread trace [1]:
Not an ARRAY reference at /usr/local/share/perl/5.10.1/OpenILS/Application/Circ/Circulate.pm line 2095.

On 2.4 pac, Internal Server Error is displayed.

Tina
Sitka

Steven Chan (schan2) on 2013-05-22
tags: added: booking
Ben Shum (bshum) on 2013-05-24
Changed in evergreen:
status: New → Triaged
importance: Undecided → Medium
Ben Shum (bshum) on 2013-08-22
no longer affects: evergreen/2.2
Shae (shae-esilibrary) wrote :

I confirm that at 2.4.2 the internal server error occurs when trying to renew an item that is bookable or has a booking reservation on it. Steps I took:

1. Set up an item to be bookable and created a reservation for it in the future (far enough that the time of the reservation wouldn't be overlapping with the checkout and renewal dates).

2. Checked the item out to my account on the training system.

3. Was able to renew the item in the staff client with no issue.

4. In the TPAC, even though it says I have 1 renewal left for the item, when I try to renew, it gives the 500 Internal Server Error.

I can renew other items on my account via TPAC with no issues.

Steven Chan (schan2) wrote :

Here is a patch for fixing the bug.

tags: added: pullrequest
tji@sitka.bclibraries.ca (tji) wrote :

Not sure this is the same issue. We have a new report that items on the booking resource list can't be checked out on self-check. After removing the item from the resource list, checkout is successful.

tji@sitka.bclibraries.ca (tji) wrote :

Can't renew on 2.6. Permission Denied.

Bill Erickson (berick) wrote :

To make it easier for the next person, I've created a branch with Steven's patch:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1175711-tpac-renew-booking-items

Note also that it *mostly* contains formatting changes. The actual fix is limited to the 2 changed lines of Circulate.pm.

Changed in evergreen:
assignee: nobody → Josh Stompro (u-launchpad-stompro-org)

I tested this on an early June version of master, following Shae's steps and received the same 500 internal server error.

I then tested it with the patch applied to master and when I try to renew an item that has a booking I get a Permission Denied error, which is better than the 500 server error, and is the behavior described in the patch. So I think this is working like it should and takes care of the 500 server error.

I have tested this code and consent to signing off on it with my
name, Josh Stompro and email address, <email address hidden>.

tags: added: signedoff
Changed in evergreen:
status: Triaged → Confirmed
assignee: Josh Stompro (u-launchpad-stompro-org) → nobody
Kathy Lussier (klussier) wrote :

Merged to master and backported to 2.9 and 2.8. Many thanks to Steven for the fix, to Bill for creating a branch in the working repository, to Josh for the testing and signoff and to Shae for providing steps to make it easier for non-booking libraries to test!

Changed in evergreen:
status: Confirmed → Fix Committed
milestone: none → 2.next
no longer affects: evergreen/2.3
no longer affects: evergreen/2.4
Changed in evergreen:
milestone: 2.next → 2.10-beta
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers