Deposit charged again on renewal of deposit item

Bug #1170794 reported by Elaine Hardy on 2013-04-19
16
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Evergreen
Medium
Unassigned

Bug Description

In EG 2.3.4

For items with deposit flag set to yes and deposit amount indicated in item attributes, we expect the deposit amount to be charged on checkout and not charged again on subsequent renewal.

Currently, there is a bug that charges deposit amounts on initial checkout and on renewal. This means that PINES patrons can be charged up to three times rather than once and library staff must void those amounts charged on renewal.

Expected behavior for deposit items is for the deposit to be charged only on checkout but not again on renewal.

Elaine Hardy (ehardy) on 2013-04-19
tags: added: cataloging circulation collection deposit
Ben Shum (bshum) on 2013-04-22
Changed in evergreen:
status: New → Triaged
Erica Rohlfs (erohlfs) wrote :

Confirming the same behavior in 2.9.

Changed in evergreen:
status: Triaged → Confirmed
importance: Undecided → Medium
no longer affects: evergreen/2.3
Erica Rohlfs (erohlfs) wrote :

Confirming the behavior exists in EG version 2.11.

no longer affects: evergreen/2.9
Changed in evergreen:
milestone: none → 2.12-beta
Jason Stephenson (jstephenson) wrote :

Here's a branch in working/user/dyrcona/lp1170794-skip-deposit-fee-on-renewal to not charge the deposit fee on renewal:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dyrcona/lp1170794-skip-deposit-fee-on-renewal

It includes a release note, but no tests. If someone wants tests, that could be added.

tags: added: pullrequest
Changed in evergreen:
assignee: nobody → Terran McCanna (tmccanna)

You are going to fix it?

J. Elaine Hardy
PINES & Collaborative Projects Manager
Georgia Public Library Service/PINES
1800 Century Place, Ste. 150
Atlanta, GA 30045

404.235.7128 Office
404.548.4241 Cell
404.235.7201 FAX

On Mon, Feb 20, 2017 at 11:41 AM, Terran McCanna <
<email address hidden>> wrote:

> ** Changed in: evergreen
> Assignee: (unassigned) => Terran McCanna (tmccanna)
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1170794
>
> Title:
> Deposit charged again on renewal of deposit item
>
> Status in Evergreen:
> Confirmed
> Status in Evergreen 2.10 series:
> Confirmed
> Status in Evergreen 2.11 series:
> Confirmed
>
> Bug description:
> In EG 2.3.4
>
> For items with deposit flag set to yes and deposit amount indicated in
> item attributes, we expect the deposit amount to be charged on
> checkout and not charged again on subsequent renewal.
>
> Currently, there is a bug that charges deposit amounts on initial
> checkout and on renewal. This means that PINES patrons can be charged
> up to three times rather than once and library staff must void those
> amounts charged on renewal.
>
> Expected behavior for deposit items is for the deposit to be charged
> only on checkout but not again on renewal.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/evergreen/+bug/1170794/+subscriptions
>

Terran McCanna (tmccanna) wrote :

Jason Stephenson created a patch for it - I am just going to test it during
bug squashing week.

Terran McCanna
PINES Program Manager
Georgia Public Library Service
1800 Century Place, Suite 150
Atlanta, GA 30345
404-235-7138
<email address hidden>

On Mon, Feb 20, 2017 at 1:18 PM, Elaine Hardy <email address hidden>
wrote:

> You are going to fix it?
>
>
> J. Elaine Hardy
> PINES & Collaborative Projects Manager
> Georgia Public Library Service/PINES
> 1800 Century Place, Ste. 150
> Atlanta, GA 30045
>
> 404.235.7128 Office
> 404.548.4241 Cell
> 404.235.7201 FAX
>
> On Mon, Feb 20, 2017 at 11:41 AM, Terran McCanna <
> <email address hidden>> wrote:
>
> > ** Changed in: evergreen
> > Assignee: (unassigned) => Terran McCanna (tmccanna)
> >
> > --
> > You received this bug notification because you are subscribed to the bug
> > report.
> > https://bugs.launchpad.net/bugs/1170794
> >
> > Title:
> > Deposit charged again on renewal of deposit item
> >
> > Status in Evergreen:
> > Confirmed
> > Status in Evergreen 2.10 series:
> > Confirmed
> > Status in Evergreen 2.11 series:
> > Confirmed
> >
> > Bug description:
> > In EG 2.3.4
> >
> > For items with deposit flag set to yes and deposit amount indicated in
> > item attributes, we expect the deposit amount to be charged on
> > checkout and not charged again on subsequent renewal.
> >
> > Currently, there is a bug that charges deposit amounts on initial
> > checkout and on renewal. This means that PINES patrons can be charged
> > up to three times rather than once and library staff must void those
> > amounts charged on renewal.
> >
> > Expected behavior for deposit items is for the deposit to be charged
> > only on checkout but not again on renewal.
> >
> > To manage notifications about this bug go to:
> > https://bugs.launchpad.net/evergreen/+bug/1170794/+subscriptions
> >
>
> --
> You received this bug notification because you are a member of Evergreen
> Bug Wranglers, which is subscribed to Evergreen.
> Matching subscriptions: ALL BUGS
> https://bugs.launchpad.net/bugs/1170794
>
> Title:
> Deposit charged again on renewal of deposit item
>
> Status in Evergreen:
> Confirmed
> Status in Evergreen 2.10 series:
> Confirmed
> Status in Evergreen 2.11 series:
> Confirmed
>
> Bug description:
> In EG 2.3.4
>
> For items with deposit flag set to yes and deposit amount indicated in
> item attributes, we expect the deposit amount to be charged on
> checkout and not charged again on subsequent renewal.
>
> Currently, there is a bug that charges deposit amounts on initial
> checkout and on renewal. This means that PINES patrons can be charged
> up to three times rather than once and library staff must void those
> amounts charged on renewal.
>
> Expected behavior for deposit items is for the deposit to be charged
> only on checkout but not again on renewal.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/evergreen/+bug/1170794/+subscriptions
>

Elaine Hardy (ehardy) wrote :
Download full text (4.6 KiB)

Wish we could get the rest of deposit fixed. It all got broken several
upgrades back when they forgot about the deposit flag on items

J. Elaine Hardy
PINES & Collaborative Projects Manager
Georgia Public Library Service/PINES
1800 Century Place, Ste. 150
Atlanta, GA 30045

404.235.7128 Office
404.548.4241 Cell
404.235.7201 FAX

On Mon, Feb 20, 2017 at 1:38 PM, Terran McCanna <
<email address hidden>> wrote:

> Jason Stephenson created a patch for it - I am just going to test it during
> bug squashing week.
>
>
> Terran McCanna
> PINES Program Manager
> Georgia Public Library Service
> 1800 Century Place, Suite 150
> Atlanta, GA 30345
> 404-235-7138
> <email address hidden>
>
>
> On Mon, Feb 20, 2017 at 1:18 PM, Elaine Hardy <<email address hidden>
> >
> wrote:
>
> > You are going to fix it?
> >
> >
> > J. Elaine Hardy
> > PINES & Collaborative Projects Manager
> > Georgia Public Library Service/PINES
> > 1800 Century Place, Ste. 150
> > Atlanta, GA 30045
> >
> > 404.235.7128 Office
> > 404.548.4241 Cell
> > 404.235.7201 FAX
> >
> > On Mon, Feb 20, 2017 at 11:41 AM, Terran McCanna <
> > <email address hidden>> wrote:
> >
> > > ** Changed in: evergreen
> > > Assignee: (unassigned) => Terran McCanna (tmccanna)
> > >
> > > --
> > > You received this bug notification because you are subscribed to the
> bug
> > > report.
> > > https://bugs.launchpad.net/bugs/1170794
> > >
> > > Title:
> > > Deposit charged again on renewal of deposit item
> > >
> > > Status in Evergreen:
> > > Confirmed
> > > Status in Evergreen 2.10 series:
> > > Confirmed
> > > Status in Evergreen 2.11 series:
> > > Confirmed
> > >
> > > Bug description:
> > > In EG 2.3.4
> > >
> > > For items with deposit flag set to yes and deposit amount indicated
> in
> > > item attributes, we expect the deposit amount to be charged on
> > > checkout and not charged again on subsequent renewal.
> > >
> > > Currently, there is a bug that charges deposit amounts on initial
> > > checkout and on renewal. This means that PINES patrons can be charged
> > > up to three times rather than once and library staff must void those
> > > amounts charged on renewal.
> > >
> > > Expected behavior for deposit items is for the deposit to be charged
> > > only on checkout but not again on renewal.
> > >
> > > To manage notifications about this bug go to:
> > > https://bugs.launchpad.net/evergreen/+bug/1170794/+subscriptions
> > >
> >
> > --
> > You received this bug notification because you are a member of Evergreen
> > Bug Wranglers, which is subscribed to Evergreen.
> > Matching subscriptions: ALL BUGS
> > https://bugs.launchpad.net/bugs/1170794
> >
> > Title:
> > Deposit charged again on renewal of deposit item
> >
> > Status in Evergreen:
> > Confirmed
> > Status in Evergreen 2.10 series:
> > Confirmed
> > Status in Evergreen 2.11 series:
> > Confirmed
> >
> > Bug description:
> > In EG 2.3.4
> >
> > For items with deposit flag set to yes and deposit amount indicated in
> > item attributes, we expect the deposit amount to be charged on
> > checkout and not charged again on subsequent renewal.
> >
> > Currently, there is a bug t...

Read more...

Terran McCanna (tmccanna) wrote :
Download full text (6.4 KiB)

Are there open bugs on the other things that broke?

Terran McCanna
PINES Program Manager
Georgia Public Library Service
1800 Century Place, Suite 150
Atlanta, GA 30345
404-235-7138
<email address hidden>

On Mon, Feb 20, 2017 at 1:55 PM, Elaine Hardy <email address hidden>
wrote:

> Wish we could get the rest of deposit fixed. It all got broken several
> upgrades back when they forgot about the deposit flag on items
>
>
> J. Elaine Hardy
> PINES & Collaborative Projects Manager
> Georgia Public Library Service/PINES
> 1800 Century Place, Ste. 150
> Atlanta, GA 30045
>
> 404.235.7128 Office
> 404.548.4241 Cell
> 404.235.7201 FAX
>
> On Mon, Feb 20, 2017 at 1:38 PM, Terran McCanna <
> <email address hidden>> wrote:
>
> > Jason Stephenson created a patch for it - I am just going to test it
> during
> > bug squashing week.
> >
> >
> > Terran McCanna
> > PINES Program Manager
> > Georgia Public Library Service
> > 1800 Century Place, Suite 150
> > Atlanta, GA 30345
> > 404-235-7138
> > <email address hidden>
> >
> >
> > On Mon, Feb 20, 2017 at 1:18 PM, Elaine Hardy <
> <email address hidden>
> > >
> > wrote:
> >
> > > You are going to fix it?
> > >
> > >
> > > J. Elaine Hardy
> > > PINES & Collaborative Projects Manager
> > > Georgia Public Library Service/PINES
> > > 1800 Century Place, Ste. 150
> > > Atlanta, GA 30045
> > >
> > > 404.235.7128 Office
> > > 404.548.4241 Cell
> > > 404.235.7201 FAX
> > >
> > > On Mon, Feb 20, 2017 at 11:41 AM, Terran McCanna <
> > > <email address hidden>> wrote:
> > >
> > > > ** Changed in: evergreen
> > > > Assignee: (unassigned) => Terran McCanna (tmccanna)
> > > >
> > > > --
> > > > You received this bug notification because you are subscribed to the
> > bug
> > > > report.
> > > > https://bugs.launchpad.net/bugs/1170794
> > > >
> > > > Title:
> > > > Deposit charged again on renewal of deposit item
> > > >
> > > > Status in Evergreen:
> > > > Confirmed
> > > > Status in Evergreen 2.10 series:
> > > > Confirmed
> > > > Status in Evergreen 2.11 series:
> > > > Confirmed
> > > >
> > > > Bug description:
> > > > In EG 2.3.4
> > > >
> > > > For items with deposit flag set to yes and deposit amount indicated
> > in
> > > > item attributes, we expect the deposit amount to be charged on
> > > > checkout and not charged again on subsequent renewal.
> > > >
> > > > Currently, there is a bug that charges deposit amounts on initial
> > > > checkout and on renewal. This means that PINES patrons can be
> charged
> > > > up to three times rather than once and library staff must void
> those
> > > > amounts charged on renewal.
> > > >
> > > > Expected behavior for deposit items is for the deposit to be
> charged
> > > > only on checkout but not again on renewal.
> > > >
> > > > To manage notifications about this bug go to:
> > > > https://bugs.launchpad.net/evergreen/+bug/1170794/+subscriptions
> > > >
> > >
> > > --
> > > You received this bug notification because you are a member of
> Evergreen
> > > Bug Wranglers, which is subscribed to Evergreen.
> > > Matching subscriptions: ALL BUGS
> > > https://bugs.launchpad.net/bugs/1170794
> > >
> > > Title...

Read more...

Dawn Dale (ddale) on 2017-02-20
Changed in evergreen:
assignee: Terran McCanna (tmccanna) → Dawn Dale (ddale)
Changed in evergreen:
assignee: Dawn Dale (ddale) → Terran McCanna (tmccanna)
Changed in evergreen:
milestone: 2.12-beta → 2.12-rc
Sam Link (slink-g) wrote :

I've found a very minor problem with the patch.

If a patron checks out the deposit item, an alert is given on the first renewal that a deposit is owed to the patron. On the second renewal, that alert does not appear, nor on check-in after a renewal. While deposit items should be marked as such, the alert makes a nice reminder to staff to actually return the deposit to the patron.

Changed in evergreen:
assignee: Terran McCanna (tmccanna) → nobody
Galen Charlton (gmc) on 2017-03-15
Changed in evergreen:
milestone: 2.12-rc → 2.12.1
Chris Sharp (chrissharp123) wrote :

I can confirm the behavior Sam describes in his comment. I've removed the pullrequest for the moment.

tags: removed: pullrequest
Kathy Lussier (klussier) on 2017-04-19
tags: added: needsrepatch
Jason Stephenson (jstephenson) wrote :

Re-assigning myself on the assumptions that I'll make some time to look at this again, soonish.

Changed in evergreen:
assignee: nobody → Jason Stephenson (jstephenson)
milestone: 2.12.1 → 3.next
Changed in evergreen:
assignee: Jason Stephenson (jstephenson) → nobody
Kathy Lussier (klussier) on 2018-03-21
no longer affects: evergreen/2.10
no longer affects: evergreen/2.11
no longer affects: evergreen/2.12
Mike Rylander (mrylander) wrote :

I'm concerned about the consequences of keeping the original circ in play and open across multiple renewals. Would it be reasonable to simply move the deposit billing line item along with the renewal by changing the xact field directly?

Something to confirm: how do opac renewals currently interact with deposits?

Andrea Neiman (aneiman) on 2019-03-05
tags: removed: collection
Rogan Hamby (rogan-hamby) wrote :

To answer Mike's question if there is a deposit amount on an item currently an opac renewal will fail with the message 'Payment of an item rental fee is required.'

Changed in evergreen:
assignee: nobody → Rogan Hamby (rogan-hamby)
Rogan Hamby (rogan-hamby) wrote :

patch here: user/rogan/lp1170794_skip_renewal_deposit_charge

This is similar to Jason's patch but maybe some things changed between then and now. Testing on master as of today showed this behavior with an item that had a deposit:

Staff Client Checkout: showed ITEM_DEPOSIT_REQUIRED message, charged amount
Staff Client Renewal: showed ITEM_DEPOSIT_REQUIRED and charged amount
OPAC Login: attempted to renew and got "Failed to renew 1 item(s)"

after patch testing gave:

Staff Client Checkout: showed ITEM_DEPOSIT_REQUIRED message, charged amount
Staff Client Renewal: did not show ITEM_DEPOSIT_REQUIRED and did not charge deposit again
OPAC Login: attempted to renew and it successfully renewed

Note, that I did find that if you are renewing from an aborted transit that message supersedes the deposit one. That may be an existing bug somewhere but I suspect is broader in scope than this testing. The behavior of the ITEM_DEPOSIT_PAID message remained consistent before and after. I'm not a fond of it's terminology but that's not in the scope of this either of course.

Changed in evergreen:
assignee: Rogan Hamby (rogan-hamby) → nobody
tags: added: pullrequest
removed: deposit needsrepatch
Elaine Hardy (ehardy) wrote :

We are trying to get this loaded on one of our stock test servers. It may be next week before we can test it but we are going to test

Elaine Hardy (ehardy) wrote :

Blake was able to put it on a sandbox for us.

I created an item on Record ID 94 with the deposit amount of $10.

1. Checked out to Patron Leon Anderson. Charged deposit correctly with warning dialog box. Paid deposit.

2. Renewed item from patron account in staff client.Dialog box for deposit already charged and for message for deposit again. Forced action and deposit was charged.

Repeated with patron Norm Barnes with same result -- deposit charged on renewal.

We had the same results in our stock test server.

Rogan Hamby (rogan-hamby) wrote :

That's not the behavior I saw so I'm removing the pull request for now to take another look at it.

Changed in evergreen:
assignee: nobody → Rogan Hamby (rogan-hamby)
tags: removed: pullrequest
Rogan Hamby (rogan-hamby) wrote :
tags: added: pullrequest
Elaine Hardy (ehardy) wrote :

Tested this on one of our test servers running stock. Still seeing a deposit charged with each renewal.

Rogan Hamby (rogan-hamby) wrote :

Interesting. I'm definitely not seeing that on my test VM. I'm going to see if I can pull in other eyes and test this. Either there is a difference in our testing environments or some workflow difference that needs accounting for. I'm leaving the pull request on for now simply because I'd like to see more eyes on it and testing.

Elaine Hardy (ehardy) wrote :

My workflow, for reference

I created an item, checked the deposit flag for yes and added 10 to the deposit amount.

Test 1:

Checked book out to stock patron at same branch as owning library.

Deposit was charged.

Renewed item. 3 part warning message: that patron exceeded fines, was charged a deposit and that deposit would be charged.

Clicked to override. Patron charged another deposit fee.

Checked book in

Test 2:

Checked book out to patron at same branch as owning library.

Patron charged deposit.
Paid deposit.
Renewed item. Two part warning message: patron was charged a deposit and patron would be charged a deposit.
Overrode for renewal.
Patron charged deposit again.

This is a server with sotck Evergreen and the concerto database(no PINES customizations).

Garry Collum (gcollum) wrote :

I tested with the concerto data and the patch worked. I edited an item and made it have a deposit amount of $1 and checked it out. The patron was charged a $1. Before I applied the patch the patron was charged upon renewal after I applied the patch the patron was not charged upon renewal.

After I applied the patch I did restart the opensrf services and apache2 before testing the affects of the patch.

Elaine Hardy (ehardy) wrote :

I'll try to test again next week. We did not have Chris's expertise today to load the patch so we might have missed something.

Changed in evergreen:
assignee: Rogan Hamby (rogan-hamby) → nobody
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers