Circulation > Clear Shelf-Expired Holds fails

[Michael Peters]

Evergreen 2.3.4
OpenSRF 2.1.2
Ubuntu 12.04
PostgreSQL 9.1.8

I'm having trouble using the Clear Shelf-Expired Holds interface in multiple 2.3.4 systems. The errors happen regardless of library size (and thus volume of holds) in both environments.

I realize this may be something that gets found to be unique to these two environments, but I wanted to throw it out there to see if other 2.3.x installations are having similar issues.

Sorry for the flood of logs!!

______________________________________________________

If you believe this error is due to a bug in Evergreen and not network problems, please contact your help desk or friendly Evergreen administrators, and give them this information:
method=open-ils.circ.hold.clear_shelf.process
params=["redacted","82"]
THROWN:
{"payload":[],"debug":"osrfMethodException : *** Call to [open-ils.circ.hold.clear_shelf.process] failed for session [1365685496.705591.136568549618701], thread trace [1]:\nException: OpenSRF::DomainObject::oilsMethodException 2013-04-11T09:05:17 OpenSRF::Application /usr/local/share/perl/5.14.2/OpenSRF/Application.pm:233 <500> No active transaction to roll back\n\n","status":500}
STATUS:

We experienced a network/server communication failure. Please check your internet connection and try this action again. Repeated failures may require attention from your local IT staff or your friendly Evergreen developers.

Error in holds.js, cmd_clear_expired_onshelf_holds

root@logger01:/var/log/evergreen/2013/04/11# grep "1365685496.705591.136568549618701" *
gateway.09.log:2013-04-11 09:05:17 brick04-head osrf_json_gw: [ERR :18701:./osrf_json_gateway.c:363:1365685376187016] Gateway received error: *** Call to [open-ils.circ.hold.clear_shelf.process] failed for session [1365685496.705591.136568549618701], thread trace [1]:#012Exception: OpenSRF::DomainObject::oilsMethodException 2013-04-11T09:05:17 OpenSRF::Application /usr/local/share/perl/5.14.2/OpenSRF/Application.pm:233 <500> No active transaction to roll back#012
gateway.09.log:2013-04-11 09:05:17 brick04-head osrf_json_gw: [info] [client 98.220.133.90] OpenSRF JSON Request returned error: osrfMethodException -> *** Call to [open-ils.circ.hold.clear_shelf.process] failed for session [1365685496.705591.136568549618701], thread trace [1]:\nException: OpenSRF::DomainObject::oilsMethodException 2013-04-11T09:05:17 OpenSRF::Application /usr/local/share/perl/5.14.2/OpenSRF/Application.pm:233 <500> No active transaction to roll back\n\n
osrferror.log:2013-04-11 09:05:17 brick04-head osrf_json_gw: [ERR :18701:./osrf_json_gateway.c:363:1365685376187016] Gateway received error: *** Call to [open-ils.circ.hold.clear_shelf.process] failed for session [1365685496.705591.136568549618701], thread trace [1]:#012Exception: OpenSRF::DomainObject::oilsMethodException 2013-04-11T09:05:17 OpenSRF::Application /usr/local/share/perl/5.14.2/OpenSRF/Application.pm:233 <500> No active transaction to roll back#012
osrfwarn.log:2013-04-11 09:05:17 brick04-head osrf_json_gw: [ERR :18701:./osrf_json_gateway.c:363:1365685376187016] Gateway received error: *** Call to [open-ils.circ.hold.clear_shelf.process] failed for session [1365685496.705591.136568549618701], thread trace [1]:#012Exception: OpenSRF::DomainObject::oilsMethodException 2013-04-11T09:05:17 OpenSRF::Application /usr/local/share/perl/5.14.2/OpenSRF/Application.pm:233 <500> No active transaction to roll back#012

srfsh# request open-ils.circ open-ils.circ.hold.clear_shelf.process "redacted", "82"

Received Exception:
Name: osrfMethodException
Status: *** Call to [open-ils.circ.hold.clear_shelf.process] failed for session [1365687267.372789.136568726729771], thread trace [1]:
Exception: OpenSRF::DomainObject::oilsMethodException 2013-04-11T09:34:45 OpenSRF::Application /usr/local/share/perl/5.14.2/OpenSRF/Application.pm:233 <500> No active transaction to roll back

Status: 500
------------------------------------
Request Completed Successfully
Request Time in seconds: 17.767006
------------------------------------

Please open a helpdesk ticket and include the following text:

Thu Apr 11 2013 10:01:19 GMT-0400 (US Eastern Daylight Time)

Error in holds.js, cmd_clear_expired_onshelf_holds

{
 "fileName":"oils://remote/xul/rel_2_3_4/server/patron/holds.js",
 "lineNumber":1875
}

[Chris Sharp (chrissharp123)]

One of our staff members just came across this. Looks like a timeout issue.

srfsh# request open-ils.circ open-ils.circ.hold.clear_shelf.process "<REDACTED>" 123

Received Data: {
  "maximum":25,
  "progress":25
}

Received Data: {
  "maximum":50,
  "progress":50
}

Received Data: {
  "maximum":75,
  "progress":75
}

Received Data: {
  "cache_key":"<REDACTED>"
}

------------------------------------
Request Completed Successfully
Request Time in seconds: 65.010084
------------------------------------

That took 65 seconds - 10 seconds longer than the staff client waits (IIRC).

[Chris Sharp (chrissharp123)]

This is still an issue in 2.5.1, FYI.

[Bill Erickson (berick)]

This ticket describes two different issues. The initial problem reported by Mike is a duplicate of bug #1133568. The second problem described by Chris, where it just takes too long, is more closely related to bug #1386347. The solution provided for bug #1386347 should help to speed up the overall process.

[Ben Shum (bshum)]

Since berick's solution for 2.8 to speed up the process was released, I think maybe this bug can be closed with a "Won't Fix" or otherwise not part of our current dev plans. If there are still issues with the hold clear shelf process, we can revisit this, otherwise just tidying up.