Database strings not marked for translation

[Pasi Kallinen]

*EG master

Strings not marked for translation in 950.data.seed-values.sql:

* 'Maximum visible age of User Trigger Events in Staff Interfaces'
* 'If this is unset, staff can view User Trigger Events regardless of age. When this is set to an interval, it represents the age of the oldest possible User Trigger Event that can be viewed.'
* 'Kid''s OPAC Search Filter'
* 'Children''s Materials'
* 'Young Adult Materials'
* 'General/Adult Materials'
* container.copy_bucket_type with label 'Circulation History'

* authority.browse_axis inserts
* config.index_normalizer inserts
* config.marc21_physical_characteristic_value_map inserts
* config.marc21_physical_characteristic_type_map inserts
* some of the config.usr_setting_type inserts
* vandelay.merge_profile inserts

[Ben Shum (bshum)]

Using this bug to track other problems with the database seed values and i18n issues.

There are mismatches in the table for entries like:

INSERT INTO config.record_attr_definition (name,label,fixed_field,description) values ('audience','Audn','Audn', oils_i18n_gettext('audience', 'Audience', 'crad', 'label'));

Where the "description" is being translated with an ID of "label" instead, leading to messiness.

Let's make this bug a better overhaul of what's in the seed data values at large and getting things in better shape for i18n purposes.

[Ben Shum (bshum)]

I have finished a working branch that addresses most of the issues noted.

See: user/bshum/lp1160347-i18n-fixes-for-db.seed

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/bshum/lp1160347-i18n-fixes-for-db.seed

The following three areas I was unsure about though:

* config.index_normalizer inserts
* config.marc21_physical_characteristic_value_map inserts
* config.marc21_physical_characteristic_type_map inserts

My question is how would these be visible to end-users?

[Ben Shum (bshum)]

Okay, in discussion with gmcharlt, determined that the config.marc21_* stuff is visible to end users as part of the catalog editors in the web client. That said, introducing that many new translations that are specific to cataloging only, I'm not 100% sure on yet.

Rebased the existing branch back onto master for more relevant testing of the fixes thus far.

[Ben Shum (bshum)]

Oh, good, there's bug 1661327 (https://bugs.launchpad.net/evergreen/+bug/1661327) that's already tracking the coded value map translations not being done. I'll use that to track that future work and consider the fixes already on here as ready for pullrequest then.

[Chris Sharp (chrissharp123)]

Works for me! Signoff branch at http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/csharp/lp1160347-i18n-fixes-for-db.seed.

[Galen Charlton (gmc)]

Pushed to master. Thanks, Ben and Chris!