Truncate fines when max fine reached

Bug #1145284 reported by Jeff Davis
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Wishlist
Unassigned

Bug Description

The max fine on a circulation is a threshold, not an absolute value. Thus, if the max fine is not a multiple of the recurring fine amount, fines will max out at a value greater than the max fine value. For example, if the recurring fine is $0.30 and the max fine is $5.00, fines will actually max out at $5.10. Some of our sites would prefer the max fine amount to be treated as an absolute value (i.e., fines would max out at $5.00).

I have a patch for this, which I will post momentarily.

Tags: pullrequest
Revision history for this message
Jeff Davis (jdavis-sitka) wrote :

Patch has been pushed to the working repo, in branch user/jeffdavis/lp1145284-truncate-to-max-fine:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commitdiff;h=5b07671a74d8b5eceb01157e3c8768c9e1c62250;hp=c0489034bcafdd720e51ee828742a4607462fb06

This adds YAOUS, circ.fines.truncate_to_max_fine, which is a simple boolean value that determines whether to treat the max fine as an absolute value (true) or as a threshold (false - current behavior).

The patch has been tested against EG 2.2.6. I haven't tested against trunk, but the patch applies cleanly; I expect it will work without any problems.

tags: added: pullrequest
Ben Shum (bshum)
Changed in evergreen:
milestone: none → 2.4.0-beta
status: New → Triaged
importance: Undecided → Wishlist
Revision history for this message
Mike Rylander (mrylander) wrote :

WFM. Thanks, Jeff!

Changed in evergreen:
status: Triaged → Fix Committed
Ben Shum (bshum)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.