action_trigger_runner help is not quite right

Bug #1133158 reported by Pasi Kallinen
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Low
Unassigned
2.6
Fix Released
Undecided
Unassigned

Bug Description

* EG master

action_trigger_runner says:
perl ./action_trigger_runner.pl --osrf-config /openils/conf/opensrf_core.xml --hooks checkout.due

but you need to use
--hooks=checkout.due

(note the equals-sign)

Revision history for this message
Ben Shum (bshum) wrote :

Confirmed and pushed a branch to fix this in: working/user/bshum/lp1133158-typo-fix

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/bshum/lp1133158-typo-fix

Changed in evergreen:
status: New → Confirmed
importance: Undecided → Low
milestone: none → 2.4.0-rc
Revision history for this message
Dan Wells (dbw2) wrote :

I think you might also need a '--process-hooks' flag on there?

Ben Shum (bshum)
Changed in evergreen:
status: Confirmed → In Progress
assignee: nobody → Ben Shum (bshum)
milestone: 2.4.0-rc → none
Revision history for this message
Josh Stompro (u-launchpad-stompro-org) wrote :

Dan, I think you are correct, the --hooks=x doesn't get used unless --process-hooks is specified.

 145 sub process_hooks {
146 $opt_verbose and print "process_hooks: " . ($opt_process_hooks ? '(start)' : 'SKIPPING') . "\n";
147 return unless $opt_process_hooks;
148
149 my @hooks = ($opt_hooks) ? split(',', $opt_hooks) : keys(%$hook_handlers);

Here is another branch that adds that option on to the change that Ben made.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/stompro/lp1133158_action_trigger_runner_typo

Josh

Revision history for this message
Ben Shum (bshum) wrote :

Change looks fine to me. Pushed to master and backported to rel_2_7 and rel_2_6. Thanks Josh!

Changed in evergreen:
milestone: none → 2.7.2
status: In Progress → Fix Committed
assignee: Ben Shum (bshum) → nobody
Galen Charlton (gmc)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.