Public hold notes do not display in tpac

[Kathy Lussier]

Evergreen version 2.3.3 and master

If you create a hold note and select the option to make it public, the note does not display for the patron when logged into tpac.

[Ben Shum (bshum)]

Incorrectly marked as duplicate. This is still a wishlist item that has not been implemented yet.

[Dan Scott (denials)]

I have created a branch to add display logic for public hold notes in the TPAC at http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dbs/tpac_public_hold_notes

The branch includes an addition to the sample Concerto data that adds two hold notes for every staff-generated hold; one is marked "public", and the other is marked as non-public. Only the public note should be displayed in a given patron's account.

[Lebbeous Fogle-Weekley (lebbeous)]

Hi Dan,

This works well, and thanks for the test data!

How do you feel about this small additional commit: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/collab/senator/tpac_public_hold_notes

I started it because for smaller screens there was no "Notes" label for the new notes row. Then I wound up removing the class attribute from the new <td> element in order to make the CSS that provides the labels for the existing small-screen rows work on the new row too. There is an admitted loss of semantic markup, but now the styling of notes content matches the rest of the table. I guess the bold/all caps style was a readability decision sometime before?

Lebbeous

[Dan Scott (denials)]

Hey Lebbeous, thanks for testing this on a smaller screen -- good catch!

As for the table CSS, yes, the all-uppercase / bold style was inherited from the KCLS skin that the TPAC was based on. That said, all-uppercase / all-bold is a style that can be harmful to readability. text-transform: uppercase in particular can cause problems for translators who think they have control over the capitalization of the words in their translation but who end up with a result that they do not anticipate. By using uppercase and bold uniformly throughout the table, we also lose the ability to emphasize specific sections of the table (such as the table header).

In general, I think "text-transform: uppercase" should simply be eradicated from our CSS. If we want uppercase text, then it should be supplied in the template and controllable by the translator, not generated by the CSS.

Setting that overall design decision aside, I strongly believe that the text of the notes should *not* be transformed into uppercase and bold. If we turn every hold note that a staff member might place into the equivalent of shouting, that could have unfortunate results. I would therefore very much prefer to keep the .hold_notes class.

[Lebbeous Fogle-Weekley (lebbeous)]

Hi Dan,

That all makes sense to me. What do you think about this branch to do it all?

The first commit gets rid of text-transform: uppercase and capitalize. The most visible case of capitalize was altogether inappropriate (applied to patron names) and the heck with the second case anyway. And it gets rid of some bold.

Then comes your commit, and finally the small-screen Notes label. In this branch, the .holds_notes class is preserved.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/collab/senator/tpac_stop_shouting_plus_hold_notes

Thanks!

Lebbeous

[Dan Scott (denials)]

That looks great - thanks Lebbeous! I've committed the changes to master.