Staged user OU setting check does not pass a context org unit, always fails

Bug #1104517 reported by Jeff Godin
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Undecided
Unassigned
2.3
Fix Released
Undecided
Unassigned
2.4
Fix Released
Undecided
Unassigned

Bug Description

The API method open-ils.actor.user.stage.create checks the OU setting opac.allow_pending_user, but in doing so fails to pass a context org unit, meaning the check will always fail.

Also related: the OU setting opac.allow_pending_user must currently be created manually.

Revision history for this message
Jeff Godin (jgodin) wrote :

The commit here contains a single commit which addresses the OU setting check, as well as IDL fixes for bug 1104516. I plan to split the changes out and will create a working branch in the usual place for signoff. For now, just getting this bug documented and the preliminary fix out there: http://git.evergreen-ils.org/?p=evergreen/tadl.git;a=commit;h=de88b461de89ca541b5f18b9f048bdeaecbff60f

Revision history for this message
Bill Erickson (berick) wrote :

Testing the patch...

Revision history for this message
Bill Erickson (berick) wrote :

I've tested the patch and confirmed it fixes stage user and billing address creation. Jeff, unless you have any objections, I'll sign-off and merge directly from your TADL patch and knock out both bugs.

Revision history for this message
Jeff Godin (jgodin) wrote :

No objection. Thanks!

Revision history for this message
Bill Erickson (berick) wrote :

Pushed to 2.3 and beyond. Thanks, Jeff.

Changed in evergreen:
milestone: none → 2.5.0-alpha1
assignee: Jeff Godin (jgodin) → nobody
status: In Progress → Fix Committed
Ben Shum (bshum)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.