Report editor uses translated string internally and crashes

[Pasi Kallinen]

Report editor does not work if REPORT_CONF_BARE is translated: Cannot select folder to save the report to.

oils_rpt_report_editor.js has the following code:

    iterate(rptObject.def.select,
        function(i) {
            if(OILS_RPT_TRANSFORMS[i.column.transform].aggregate)
                hasAgg = true;
        }
    );

The value of i.column.transform is the translated value of REPORT_CONF_BARE, and the array OILS_RPT_TRANSFORMS wants the transform name "Bare" in English.

[Chris Sharp (chrissharp123)]

This may or may not be the same issue, but I'm seeing this JS console error:

TypeError OILS_RPT_TRANSFORMS[par.column.transform] is undefined
oils://remote/reports/oils_report_param_editor.js, line 56

when I have selected a "substring" transform for a field. Same symptoms, my folders for saving the report definition and output are missing, as is the value of the substring I've selected.

[Eva Cerninakova (ece)]

I have discovered problem when testing and using Evergreen 2.5.3 and 2.6.2: if the non English locale in the staff client is used when creating a report template, it is impossible to create report from such a template. I came accross the same problem some time ago in Evergreen 2.2 and reported it as a bug 1131373 (which should be duplicate of this one - see https://bugs.launchpad.net/evergreen/+bug/1131373) .

[Eva Cerninakova (ece)]

Tested in EG 2.12 (version 0master.53150bb)
The problem still remains in Evergreen

[Eva Cerninakova (ece)]

I have checked this in 3.0 beta sandbox.
- In XUL client the problem is still there.
- I was not able to confirm whether the problem still persists in web staff client as currently some parts of reporter interfaces appear untranslated (including the list of sources a list o source specifiers in the report template building interface).

[Eva Cerninakova (ece)]

The problem has remained until 3.1 in XUL client (I was unable to test in web staff client as the list of sources and source specifier are dispayed untranslated in 3.1 web client).

However, I have checked this problem in the 3.2 beta sandbox and the templates created using Czech interface (with sources and source specifiers displayed translated to Czech properly) and I was able to create a report normally from the template and see the report output.
So I can say the bug has been resolved in 3.2 web staff client.

[Remington Steed (rjs7)]

I'll mark this as "Fix committed" for 3.2, since Eva's testing has mostly confirmed the timing of the fix.