Reserve room for system config.metabib_field values

[Dan Scott]

* Evergreen 2.3 and prior

Per http://list.georgialibraries.org/pipermail/open-ils-dev/2013-January/008747.html we should set the value of config.metabib_field_id_seq to something high enough that we can add new stock entries without causing upgrade conflicts.

So, something like changing Open-ILS/src/sql/Pg/950.data.seed-values.sql around 178 to read:

SELECT SETVAL('config.metabib_field_id_seq'::TEXT, 100, TRUE);

[Dan Scott (denials)]

For that matter, the same problem applies to:

SELECT SETVAL('permission.grp_tree_id_seq'::TEXT, (SELECT MAX(id) FROM permission.grp_tree));

SELECT SETVAL('permission.grp_penalty_threshold_id_seq'::TEXT, (SELECT MAX(id) FROM permission.grp_penalty_threshold));

SELECT SETVAL('permission.grp_perm_map_id_seq'::TEXT, (SELECT MAX(id) FROM permission.grp_perm_map));

Maybe we want to make the value 1000 instead of 100? Integers are cheap...

[Bill Erickson (berick)]

>
> Maybe we want to make the value 1000 instead of 100? Integers are
> cheap...
>

+1

--
Bill Erickson
| Senior Software Developer
| phone: 877-OPEN-ILS (673-6457)
| email: <email address hidden>
| web: http://esilibrary.com
| Equinox Software, Inc. / Your Library's Guide to Open Source

[Alex Lazar (alex-lazar)]

For the PK serial field, would it work to omit specifying the primary key altogether or use DEFAULT in the INSERT statement? The next one serially would be generated automatically.

[Ben Shum (bshum)]

Re-confirming this bug and forwarding a working branch by Dyrcona in another ticket: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dyrcona/lp1178393

[Dan Wells (dbw2)]

Pushed this commit (with bump to 1000) to help with wrapping up bug #1235497.

[Dan Wells (dbw2)]

Also, setting 'In Progress', as upgrade scripts forthcoming...

[Dan Wells (dbw2)]

Upgrade scripts are now added, marking as 'fix committed'. Thanks, all.

[Alex Lazar (alex-lazar)]

Just for the record, I think my question in Comment #3 was narrowly focusing on the specific issue I originally encountered and missed the larger goal of this bug. Many thanks for addressing the issue!