Record navigation template has a translatable arrow

[Pasi Kallinen]

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/paxed/navarrowfixes

Wraps all the navigation arrow characters in the nav_arrow_fix span, and moves the arrow outside the translatable string - it makes no sense having it translatable.

[Dan Scott (denials)]

Well, actually... we've had people who have wanted to use different arrow characters, for whatever reason. Having it be translatable makes it easier to supply a different tpac.po file. Whether it's translatable or not, it should at least be consistent, though, which it is not currently. Also, I dunno - would it make sense for a right-to-left language to want to put the arrow symbol on the other side and facing the other way?

Aside: in your branch, was there a reason to wrap the arrows in <span> tags? That seems to introduce extra markup for no discernible reason.

[Pasi Kallinen (paxed)]

Making the arrow character(s) configurable would be good, but I don't know if the character should be in the po-file - not all translators know how to handle HTML, and I believe RTL languages would have to edit the templates quite heavily anyway. (Although I haven't had anything to do with RTL languages, so I'm just guesstimating)

Most of the arrows are outside the translatable strings, and wrapped in span, see eg. grep -E "&#x?[0-9a-fA-F]+;" `find . -name \*.tt2`

[Ben Shum (bshum)]

Fwiw, I see what paxed was saying about other examples where the arrow was put in <span> for other files. Notably results/paginate.tt2 is like that.

dbs, any final thoughts on the changes here? Or revised approaches?

[Kathy Lussier (klussier)]

Pasi's branch is consistent with the code used for other navigational arrows in the catalog, so I've added a sign-off to the code.

I don't think it's a bad idea to provide a way for sites to use other navigational arrows, but, if we do so, I think it's best if we have a branch that does it for all arrows, not just the ones used on the record page.

My signoff is available at:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/kmlussier/lp1095290-narrowfixes

[Ben Shum (bshum)]

Picked with Kathy's signoff to master only, since this invokes string changes.

Reminder to move this to a real 2.next milestone later.

[Ben Shum (bshum)]

Changing milestone to reflect real target of 2.8 series - 2.8 beta, here we come!