serials: deleting an issuance does not update the basic summary statement

Bug #1078593 reported by Kathy Lussier on 2012-11-14
22
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Evergreen
Medium
Unassigned
2.5
Medium
Unassigned
2.6
Medium
Unassigned
2.7
Undecided
Unassigned

Bug Description

Evergreen version 2.2.3

Deleting an issuance either through the Serials Control View or the Alternate Serials Control View does not update the basic summary display in tpac.

Working on a record with a basic summary that displayed as no.27(2012:Jul.08) - no.38(2012:Sep.23), I took the following steps:

I deleted the July 8 (no. 27) issuance in Serials Control View. The basic summary statement continued to display as no.27(2012:Jul.08) - no.38(2012:Sep.23). When drilling down to specific issues with a compressed serial holdings display, this issuance was removed. It just wasn't reflected in the summary statement.

I then went to the issuance tab in the Alternate Serials Control View. The July 8 issuance continued to display there. I deleted this issuance along with the July 15 (no. 28) issuance. The basic summary statement continued to display as no.27(2012:Jul.08) - no.38(2012:Sep.23)

Changed in evergreen:
status: New → Triaged
Dan Wells (dbw2) wrote :

Code to address this now exists here:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dbwells/lp1078593_regen_summaries

It consists of three commits:

1) Assorted Serial.pm bug fixes
2) Addition of summary regeneration methods to Serial.pm
3) Tying the regeneration code into the delete process for both serials interfaces

For more details, see the commit messages.

Many thanks to MassLNC for sponsoring this development!

Changed in evergreen:
milestone: none → 2.next
importance: Undecided → Medium
Dan Wells (dbw2) on 2014-04-22
tags: added: pullrequest
Kathy Lussier (klussier) wrote :

Thanks Dan! I finally had a chance to look at this code this evening. Deleting issuances from the Serials Control View and Alternate Serials Control View did regenerate the summary statement.

However, while in the Serial Control View, I noticed that if you delete an item while in the item tab, the summary statement does not update. I know the original bug report specified issuances, but would it be possible to regenerate the summaries when those items are deleted as well?

Thanks again!
Kathy

Dan Wells (dbw2) wrote :

Kathy, thanks for testing. Items are somewhat more difficult, being more more step removed from the summaries than issuances. Still, I tried to make the regeneration code flexible enough to come from different angles, so I'll take a shot at this and see how hard it proves to be.

Removing pullrequest, for now.

Changed in evergreen:
assignee: nobody → Dan Wells (dbw2)
tags: removed: pullrequest
Ben Shum (bshum) wrote :

Removing milestones and setting status to "In Progress" while Dan works on resolving the issues noted by Kathy.

Changed in evergreen:
status: Triaged → In Progress
Kathy Lussier (klussier) wrote :

I'm going to assign it to myself and take a second look at it. I've been thinking it might be a good idea to put it in, as is, and create a separate LP bug if I still think it's needed, but I just haven't gotten around to it yet. Thanks for the prod Ben!

Changed in evergreen:
assignee: Dan Wells (dbw2) → Kathy Lussier (klussier)
Kathy Lussier (klussier) wrote :

The signoff branch is below. The summary is regenerating when issuances are deleted in the Serials Control View and the Alternate Serials Control View. I'll file a separate bug to have the same happen when items are deleted.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/kmlussier/lp1078593_regen_summaries

Changed in evergreen:
assignee: Kathy Lussier (klussier) → nobody
tags: added: pullrequest signedoff
Changed in evergreen:
status: In Progress → Triaged
Ben Shum (bshum) wrote :

Thanks for the signoff Kathy.

Picked the changes into master and backported to rel_2_7 and rel_2_6.

Changed in evergreen:
status: Triaged → Fix Committed
milestone: 2.next → 2.8-beta
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers