"ITEM_ON_HOLDS_SHELF" event message not specific enough for all use cases

[Chris Sharp]

The current ITEM_ON_HOLDS_SHELF message wording is "This requested item is currently on the holds shelf", which is intended to prevent hold shelf items from accidentally being checked out. I'm told by one of our library directors that a common use case involves staff pulling an item on hold for *another* patron with a similar/same name and attempting to check the item out to the wrong patron. Staff see the current wording and assume that the system is unnecessarily telling them that the item is on the holds shelf for the patron to whom they are attempting checkout and will override it without realizing that the item is being checked out to the wrong patron. I suggest the following wording change:

"This item is currently on the holds shelf for another patron."

That would be minimal. Ideally, the message would also include the patron for whom the item is intended as well, in which case the wording:

"This item is currently on the holds shelf for Jane Doe (2201100000001)"

would be completely unambiguous.

Evergreen 2.1.1
OpenSRF 2.0.1
PostgreSQL 9.1
Debian squeeze

[Chris Sharp (chrissharp123)]

Created branch for the first wording option:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/csharp/item_on_holds_shelf

[Ben Shum (bshum)]

I think I like the second option for its specificity. But I can see how the first would be a good place to start too.

Marking as a potential feature for 2.4.

[Dawn Dale (ddale)]

"I have tested this code and consent to signing off on it with my name, Dawn Dale and email address, <email address hidden>

[Kathy Lussier (klussier)]

Hi Chris,

This looks good, but can you add your signoff the commit? It probably could use a very small release notes entry, but I can add that when I merge the code.

Thanks!
Kathy

[Chris Sharp (chrissharp123)]

Okay, signed off and rebased to current master. New branch:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/csharp/lp1077947_item_on_hold_shelf

[Kathy Lussier (klussier)]

Thanks Chris! Merging to master for inclusion in 2.12.