add qstore to eg_db_config.pl --update-config list

[Jason Etheridge]

collab/phasefx/qstore_db_config @ working/Evergreen.git
http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/collab/phasefx/qstore_db_config

commit 2d250dc99bb5baa379ae668d33043fbd1fd1d2e0
Author: Jason Etheridge <email address hidden>
Date: Fri Nov 9 16:47:36 2012 -0500

    add qstore to eg_db_config.pl --update-config list

    Signed-off-by: Jason Etheridge <email address hidden>

diff --git a/Open-ILS/src/support-scripts/eg_db_config.pl b/Open-ILS/src/support-scripts/eg_db_config.pl
index e98710f..b1e5b90 100755
--- a/Open-ILS/src/support-scripts/eg_db_config.pl
+++ b/Open-ILS/src/support-scripts/eg_db_config.pl
@@ -236,7 +236,7 @@ GetOptions("create-schema" => \$cschema,
 );

 if (grep(/^all$/, @services)) {
- @services = qw/reporter open-ils.cstore open-ils.pcrud open-ils.storage open-ils.reporter-store state_store/;
+ @services = qw/reporter open-ils.cstore open-ils.pcrud open-ils.storage open-ils.reporter-store state_store open-ils.qstore/;
 }

 my $eg_config = File::Spec->catfile($script_dir, '../extras/eg_config');

[Dan Scott (denials)]

I was considering ripping qstore out, as as far as I can tell it's not used anywhere and hasn't been for years.

[Jason Stephenson (jstephenson)]

Yeah, I actually thought "Wait, something uses qstore?" when I read the bug summary.

I'm inclined to agree with Dan.

[Ben Shum (bshum)]

To rip out qstore or not to? :)

[Lebbeous Fogle-Weekley (lebbeous)]

I say remove it. It's a shame to lose work well done, but it seems nobody's speaking up for any projects that would use it, and nothing's using it today. If I've missed something somehow, somebody can correct me.

[Galen Charlton (gmc)]

Reviving this, since with bug 1689608 we're about to have something that actually uses qstore. However, some thought should be given as to whether to attempt to automatically update opensrf.xml during upgrade to plug in current DB credentials, or just provide an upgrade note.

[Galen Charlton (gmc)]

I just noticed that the upgrade doc contains standing instructions to run eg_db_config, so that suffices. I've gone ahead and tested and signed off on the patch; branch is user/gmcharlt/lp1077212_signoff.

[Galen Charlton (gmc)]

Pushed to master. Thanks, Jason!