Add is_tt2() like is_json() to database, constraint on atevdef.template

[Lebbeous Fogle-Weekley]

Today we give users few or no tools to test the TT2 markup they may enter when editing the template field of Action Trigger Event Definitions.

This could be a start to addressing that. It's just a database-level constraint around a function called is_tt2() that simply verifies that a given template compiles. It doesn't run the result, and it can't tell you whether your variables are defined or anything like that, and specific error messages don't bubble up to users using the staff client admin interfaces to edit templates or anything like that.

But it is at least a quick resource at the database level that will let you know when you haven't balanced all your IFs with ENDs, and that sort of thing.

Open to improvements, or merging as-is with proper testing/sign-off.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/collab/senator/schema-is-tt2

[Lebbeous Fogle-Weekley (lebbeous)]

Of course what this really needs is a pgtap unit test!

[Ben Shum (bshum)]

Tested this and the upgrade script will fail if the DB applied doesn't have Template installed. If we add this, we'll have to include another required dependency for that in the README for standalone DB servers.

Error like:

ERROR: Can't locate Template.pm in @INC (@INC contains: /etc/perl /usr/local/lib/perl/5.10.1 /usr/local/share/perl/5.10.1 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.10 /usr/share/perl/5.10 /usr/local/lib/site_perl .) at line 5.
BEGIN failed--compilation aborted at line 5.
CONTEXT: compilation of PL/Perl function "is_tt2"

[Bill Erickson (berick)]

Two things:

1. It seems that any value I pass to is_tt2() always results in TRUE. I can't make the check fail.

2. I've pushed a commit to working/user/berick/lp1066329-schema-is-tt2 which contains the needed INSTALL notes and release notes Upgrade Notes addition.

[Kathy Lussier (klussier)]

What is the status of this bug? Should it still be set to Incomplete?

[Galen Charlton (gmc)]

Grabbing this to tidy up (by adding a pgTap test case and so forth).