More tests: Perl-Critic and TT2 template parsing

[Dan Scott]

Per the hack-a-way discussion around low-hanging fruit, integrate Test-Perl-Critic-Progressive to begin failing when we introduce more Perl-Critic violations into our code base; the goal should be to eventually eliminate all of its complaints, but as long as we don't make it worse the test wont complain. Note that this test will create a new directory in $HOME, called '.evergreen-tests, so that it will persist between runs.

Also wrap a small test around the TT2 string extracter, which (as Bill noted) kindly validates the templates as it does so, thus acting as a perfect canary in the coal mine. I tested by deliberating introducing some errors in some templates and the test correctly flagged the violations.

[Dan Scott (denials)]

Ah, and the code is in working/user/dbs/more-perl-tests (http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dbs/more-perl-tests).

[Bill Erickson (berick)]

Pushed follow-up commit to include perlcritic prereqs in Makefile.install. (I assume we want them there?).

working => collab/berick/dbs-more-perl-tests

[Dan Scott (denials)]

I was deliberately not adding the test-only dependencies, thinking there
was no reason to add to the install surface for a non-dev production
server, but could certainly be convinced otherwise...

[Jason Etheridge (phasefx)]

Maybe have a special make target for them

On 10/13/12, Dan Scott <email address hidden> wrote:
> I was deliberately not adding the test-only dependencies, thinking there
> was no reason to add to the install surface for a non-dev production
> server, but could certainly be convinced otherwise...
>
> --
> You received this bug notification because you are a member of Evergreen
> Bug Wranglers, which is subscribed to Evergreen.
> https://bugs.launchpad.net/bugs/1066226
>
> Title:
> More tests: Perl-Critic and TT2 template parsing
>
> Status in Evergreen - Open ILS:
> New
>
> Bug description:
> Per the hack-a-way discussion around low-hanging fruit, integrate
> Test-Perl-Critic-Progressive to begin failing when we introduce more
> Perl-Critic violations into our code base; the goal should be to
> eventually eliminate all of its complaints, but as long as we don't
> make it worse the test wont complain. Note that this test will create
> a new directory in $HOME, called '.evergreen-tests, so that it will
> persist between runs.
>
> Also wrap a small test around the TT2 string extracter, which (as Bill
> noted) kindly validates the templates as it does so, thus acting as a
> perfect canary in the coal mine. I tested by deliberating introducing
> some errors in some templates and the test correctly flagged the
> violations.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/evergreen/+bug/1066226/+subscriptions
>

--
Sent from my mobile device

Jason

[Bill Erickson (berick)]

I'm leaving the pre-req question unanswered for now, since it's simple enough to resolve manually (and it's holding up the ticket).

Tested with good and bad templates. Looks good. Merged to master. Thanks, Dan!