Added content by record ID

Bug #1065378 reported by Jeff Godin
26
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Wishlist
Unassigned

Bug Description

This is a wishlist bug.

Some added content sources support keys other than ISBN, such as UPC.

Local image overrides are currently only possible with ISBN. In some cases, this means that a fake ISBN needs to be added to a record in order to supply a local image.

There is benefit to be had in being able to request AC by record ID, and having the AC handlers extract any keys they like. Extracting ISBN and UPC makes sense for most, and can be done in a common place.

The idea is to implement in a way which is backward compatible -- not breaking any previously working URLs. If desired, an option may be supplied in the future to turn off the old-style URLs.

An example, for a jacket image:

old style: /opac/extras/ac/jacket/medium/ISBN
new style: /opac/extras/ac/jacket/medium/r/RECORD_ID

Changes will affect OpenILS::WWW::AddedContent, some/all modules under that namespace, and the OPAC.

Updated working branch to follow.

Revision history for this message
Michael Peters (mrpeters) wrote :

I've had the pleasure of testing this out and it is FANTASTIC! The coverage for things like DVD's, CD's, etc. really goes up within our Syndetics subscription. So much more added content will become available to patrons with this code and a quality AC provider.

Ben Shum (bshum)
Changed in evergreen:
milestone: 2.4.0-alpha1 → 2.4.0-beta
Ben Shum (bshum)
Changed in evergreen:
milestone: 2.4.0-beta → 2.4.0-rc
Ben Shum (bshum)
Changed in evergreen:
milestone: 2.4.0-rc → 2.5.0-alpha
Dan Wells (dbw2)
Changed in evergreen:
milestone: 2.5.0-m1 → 2.5.0-m2
Revision history for this message
Yamil (ysuarez) wrote :

Do you have a public "working" git branch I could look at so I can hack one of my test VMs to test out this code? I tried looking, but I don't think I found it.

Thanks in advance,
Yamil

Dan Wells (dbw2)
Changed in evergreen:
milestone: 2.5.0-m2 → 2.5.0-alpha1
Remington Steed (rjs7)
Changed in evergreen:
milestone: 2.5.0-alpha1 → 2.5.0-alpha2
Dan Wells (dbw2)
Changed in evergreen:
milestone: 2.5.0-alpha2 → 2.5.0-beta1
Revision history for this message
Jeff Godin (jgodin) wrote :
Revision history for this message
Jeff Godin (jgodin) wrote :

Still needed before pullrequest: release notes and an Apache config change to support 1x1 blank.png on 404 for jackets in general.

Revision history for this message
Jeff Godin (jgodin) wrote :

Added Apache config examples and release notes and force-pushed rebased branch to user/jeff/ac_by_record_id_2013_rebase

Adding pullrequest tag.

tags: added: pullrequest
Revision history for this message
Ben Shum (bshum) wrote :

Been using the UPC stuff for quite awhile now, and the ISSN stuff looks to be fine as well.

Thanks to Yamil for providing Syndetics help and testing as well. And thanks Jeff for the fine features.

Pushed to master at last!

Changed in evergreen:
status: In Progress → Fix Committed
assignee: Jeff Godin (jgodin) → nobody
Dan Wells (dbw2)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.