TPAC facet display less user-friendly than JSPAC

[Lebbeous Fogle-Weekley]

For Evergreen 2.4+?

After a talk with Dan Wells I understand at least a couple of shortcomings in the way the TPAC display facets compared to the way JSPAC did.

1) In the JSPAC, you see five by default, and you can click "more" if you want to see them all (per facet category). In TPAC you start out seeing all of them, and you can totally collapse (show zero) any category. This is not that great, because you get very long rendered pages on a lot of records, and the only way to get the page size more reasonable is to totally hide whole categories of facets.

2) In TPAC, there appears to be no sorting of the facets within a category that have the same number of records by them. Facets are sorted by number of records, but within the same number they're not alphabetically sorted like they were for JSPAC.

[Lebbeous Fogle-Weekley (lebbeous)]

Kathy Lussier points out that in my point #1 above, TPAC doesn't show all of the facets, but only the first ten, with no way at all to see the rest of them.

So that needs fixing even worse. And ten by default can still make pages too long.

[Lebbeous Fogle-Weekley (lebbeous)]

Here's a solution that I believe makes TPAC facet display behave as it's supposed to (or as it did in JSPAC; po-tay-to po-tah-to):

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/collab/senator/tpac-facet-better

Dan, I'd particularly appreciate it if you tried this out (but other people are just as welcome as always, obviously). We did talk about maybe gradually introducing some JS back into the TPAC for usability in situations just like this one, and that can always be done later, but for now this solves the problems mentioned on this LP bug in the fully non-JS way, right?

I'd also like to hear opinions on whether this constitutes a backportable bugfix. It is conceivable that some people actually prefer the current TPAC behavior without this patch.

[Kathy Lussier (klussier)]

Lebbeous,

This looks great to me and addresses many of the concerns I've heard about tpac facet display. I've added a sign off at http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/kmlussier/tpac-facet-better.

I would happily support making it backportable.

Kathy

[Lebbeous Fogle-Weekley (lebbeous)]

Thanks Kathy!

I think not being able to see more than ten facets with the existing code is enough of a bug to justify this as a bugfix, so I've pushed to master and backported this through rel_2_2.