Patron's name not listed when placing hold through TPAC staff client

[Sarah Childs]

When you enter the barcode to place a hold it loads user preferences, but doesn't display the user's name.

The Set hold options screen in the JSPac displayed the name of the patron, giving staff the chance to confirm that the hold is being placed for the correct person. Now there is no intervening screen, and it just jumps to a hold placed or not placed confirmation.

If you are keying in the patron number, and miskey (or correctly enter a wrong number mistakenly provided by a patron) a valid number, you won't know that the hold was placed for the wrong person until the complaints roll in.

[Michael Peters (mrpeters)]

Upon placing the patron barcode in the text box, a lookup occurs to find the patron's hold notification preferences. This leads me to believe there is someplace we could easily look up the patron's name and place it beside the barcode input for confirmation.

[Thomas Berezansky (tsbere)]

I whipped up a quick fix for this.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/tsbere/hold_patron_name

And Michael Peters signed off on it already:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mrpeters-isl/hold_patron_name_signoff

[Michael Peters (mrpeters)]

Signed-off. Working great in master.

To <email address hidden>:working/Evergreen.git
 * [new branch] hold_patron_name_signoff -> user/mrpeters-isl/hold_patron_name_signoff

[Thomas Berezansky (tsbere)]

I just added another fix commit to my branch (and rebased it onto master) to fix starting with a valid barcode, going to an invalid one, then going back to the original valid one. Needs testing, though.

And as I said in IRC, I personally disagree with the added "Place hold for" label.

[Thomas Berezansky (tsbere)]

I have pushed http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/tsbere/hold_patron_name_rn with the rest of the work signed off (by myself, Mike, and Ben), plus two additional commits.

One is a basic release notes entry, the other adds some styling and fixes an issue when clearing the patron barcode.

[Michael Peters (mrpeters)]

Thomas' last two commits work great. Signed off on them at user/mrpeters-isl/hold_patron_rn_signoff.

[Ben Shum (bshum)]

Yep, styling is great!

Thanks tsbere and mrpeters.

Pushed to master for 2.4 new feature goodness!

[Ben Shum (bshum)]

Grabbing tsbere's quick fix in http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/tsbere/hold_paste_barcode

This calms staff who don't like hitting tab/enter after copy/pasting a barcode into the place hold page.