Duplicate "Require patron password" entries for Selfcheck

Bug #1053503 reported by Michael Peters
18
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Evergreen
Confirmed
Low
Unassigned

Bug Description

Evergreen 2.2 through master (and maybe earlier than 2.2)

The library settings editor contains duplicate entries for "Require Patron Password" and "Require patron password" labels.

Each has it's own "name" in config.org_unit_setting_type:

   * circ.selfcheck.patron_password_required
   * circ.selfcheck.require_patron_password

A quick rgrep through the code notes that "circ.selfcheck.patron_password_required" is used by selfcheck/selfcheck.js, but the "circ.selfcheck.require_patron_password" doesn't reveal any hits outside of the .po and .sql files in the code base.

It's possible that both are valid, because of having both JS and TT selfchecks, however, if that is the case we should update the labels/descriptions to make clear which selfcheck will be impacted by the org unit setting.

If one is unnecessary, we should remove it from the database and the SQL scripts that create it.

Revision history for this message
Jason Stephenson (jstephenson) wrote :

Requires confirmation from someone other than the submitter.

Changed in evergreen:
status: New → Incomplete
Changed in evergreen:
status: Incomplete → Triaged
Revision history for this message
Ben Shum (bshum) wrote :

I have both of those settings in my config.org_unit_setting table. So I can confirm this.

Changed in evergreen:
status: Triaged → Confirmed
Revision history for this message
Carrie Curie (carrie-curie) wrote :

The top entry "Require Patron Password" works with the https://hostname/eg/circ/selfcheck/main selfcheck interface.

Could the second entry have at one time worked with the https://hostname/opac/extras/selfcheck/selfcheck.xml? Or, possibly even another selfcheck version?

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.