renew items screen allows wacky backdating of due dates

[James Fournie]

Evergreen: 2.2

Under the menu item Circulation -> Renew Items, it is possible to set the due date to ancient times such as the year 0017. This works ok until you try to check the item in.

[Michael Peters (mrpeters)]

We've seen this recently too. I guess the fix would be making sure the due date is sometime in the future?

[Chris Sharp (chrissharp123)]

In current master I'm not able to set the year to 0017, and if I set the date to something in the past, I get a red box around the date and time boxes. I'm not able to reproduce this so assuming it got fixed somewhere along the way.

[Andrea Neiman (aneiman)]

3.1.5 web client, I can set the date to 0017-08-08 but the checkin will fail (no visual warning, but if audio alerts are turned on you get the 'Error' audio alert). Any/all backdates have a red box at the top to show you that you're in a backdated mode.

I'm leaving this open though & setting back to Confirmed, because I can see the argument for constraining the backdate to something reasonable like within the preceding year (or, say, the preceding two millennia).

[Andrea Neiman (aneiman)]

Nope, so, let me amend my above comment while actually in the correct interface -- RENEW -- as opposed to checkin, which is what I was looking at in comment #3.

In the web client, 3.1.5, you can absolutely renew an item with a due date in the past (even in the WAY past) with no error, red box, sound, or other indication that you may be doing a foolish thing.

And then you can't check in the item (database update error) until you manually edit the due date to be something sensible.

Still leaving the confirmation up.

[Kyle Huckins (khuckins)]

I've pushed a branch to prevent the selection(via using the date-picker or manually inputting via the input field) a due date in the past for the Circulation->Renew Items UI.

It can be found here: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/khuckins/lp1034058-can-renew-item-due-date-in-past

[Kyle Huckins (khuckins)]

I noticed the same issue with the Patron Items Out UI's Renew with Specific Due Date action, and have applied my fix to that UI as well, and rebased to the latest master.

[Galen Charlton (gmc)]

Patch works for me. Signoff branch is user/gmcharlt/lp1034058_signoff

[Galen Charlton (gmc)]

While looking at this again, I noticed that this was pushed to master on 8/1 by Chris (inadvertently?). In any event, the patch is good, so I've gone ahead and backported it to rel_3_3, rel_3_2, and rel_3_1. Thanks, Kyle and Chris!