Util.js trim doesn't do what it says.

[Joseph]

The Javascript function trim()'s regex expression found in Util.js doesn't actually strip all trailing whitespace from the string given.

/^\s*(.+)?\s*$/

It looks like one of the ending spaces is removed, not all.

Tested in: Chromium 18.0.1025.168, Firefox 14.0.0.1
Evergreen Version: Head

[Joseph (joehms22)]

Branch: http://git.evergreen-ils.org/?p=evergreen/joelewis.git;a=shortlog;h=refs/heads/lp_1028544

[Thomas Berezansky (tsbere)]

Would

return s.replace(/^\s*.*?\s*$/,"$1");

be a better choice?

[Joseph (joehms22)]

I still get blank space at the end of that one:

s.replace(/^\s*(.*)?\s*$/,"$1");

[Joseph (joehms22)]

An interesting discussion is here: http://blog.stevenlevithan.com/archives/faster-trim-javascript

Upon further investigation it looks like dojo also provides the same functionality under dojo.trim; falling back on to the browser's native String.trim if it has one.

[Thomas Berezansky (tsbere)]

Whoops, sorry, forgot the capture group. >_>

s.replace(/^\s*(.*?)\s*$/,"$1");

The ? after the * makes it non-greedy.

[Joseph (joehms22)]

I updated the branch to work with this function, and it indeed works when I test using the JS Scratchpad in Firefox.

[Dan Scott (denials)]

Hi Joseph:

Was there any reason you opted not to use dojo.trim()? I would generally prefer to lean on the framework to handle utility functions like this whenever possible, rather than on our own implementation.

[Joseph (joehms22)]

I wasn't entirely sure if there was a reson for having our own script over Dojo's or the native browser's, like an old xulrunner. If memory serves me right, there was only one file to even use that function, so I'll can just lob it off entirely if that works.

[Ben Shum (bshum)]

Might be something we can pull out of this?

[Kathy Lussier (klussier)]

Removing pullrequest tag on this one for now.