TPAC: Journal title search

[Dan Scott]

* Evergreen master

user/dbs/tpac_jtitle in working contains a minor hack to provide easy access to a Journal Title search in the TPAC.

This feature is required by academic users. Adding a separate bib_level selector to the basic search would only complicate the interface and would not solve the core problem, which is that users expect "Journal Title" in the same widget as "Title" and "Keyword".

We should have a separate bug to add "bib_level" to the set of filters in Advanced search, but that would not remove the need for this.

Also -- I didn't tag this onto # 821568 because that was specifically for JSPAC, and as JSPAC is deprecated there's no point in saddling it with a new feature that could legitimately be added to 2.3.0.

[Dan Wells (dbw2)]

One less local customization for all academics, everywhere...

Pushed! Thanks, Dan.

[Dan Scott (denials)]

Oddly, prepending bib_level to the query does not work (throws a database error), but appending it does. This seems surprising, but going with the flow I've created user/dbs/fix_jtitle_search in working to fix it.

[Dan Scott (denials)]

So, this is more broken now since the commit for bug #1044721 - accordingly, I've pushed another branch at user/dbs/tpac_fix_jtitle_regression with the tiny fix required to get Journal Title searches working again.

[Dan Wells (dbw2)]

Tested and working, pushed to master and rel_2_3. Thanks, Dan!

Though I thought it was important to get this fix in, I did push a branch with one small change. All it does is remove the now unneeded '$q' variable. Not a big deal, so take it or leave it, but I thought it this is ever going to get cleaned out, now is the time. If you decide to go with 'leave it', then just mark this bug as fix committed.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dbwells/jtitle_small_cleanup

user/dbwells/jtitle_small_cleanup

Thanks again,
Dan

[Dan Scott (denials)]

Clean working code trumps working code, so I've pushed your commit into master & rel_2_3 and am now marking this as "fix committed". Thanks!